RE: RFR(s): Support graceful application termination on Windows shutdown/logoff

2020-07-30 Thread Nikola Grcevski
://bugs.openjdk.java.net/browse/JDK-7068835 -Original Message- From: David Holmes Sent: July 23, 2020 11:02 PM To: Nikola Grcevski ; core-libs-dev Libs Cc: hotspot-runtime-...@openjdk.java.net Subject: Re: RFR(s): Support graceful application termination on Windows shutdown/logoff Hi Nikola, I'm

RFR: JDK-8232092: (fs) Files::isWritable returns false on a writeable root directory (win)

2020-07-06 Thread Nikola Grcevski
like GetFinalPathNameByHandleW, will fail because ImDisk does not interact with Windows Volume Mount Manager at all, it effectively bypasses it. Essentially, GetFinalPathNameByHandle and few other APIs will never work properly with ImDisk virtual drives. Cheers, Nikola Grcevski Microsoft dif

RE: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-12 Thread Nikola Grcevski
- From: Kumar Srinivasan Sent: December 12, 2019 8:32 AM To: Henry Jen Cc: core-libs-dev@openjdk.java.net; Nikola Grcevski Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate Hi Henry, I approve this. Appreciate you pushing it, as usual *all* possible tests need to be run. ;) Nikola

RE: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-11 Thread Nikola Grcevski
// deemed as application arguments + OutputAnalyzer output = ProcessTools.executeProcess( +createProcessWithLauncherDebugging( +"--module-path=" + dir, +"--module=" + mid, +"--module-path=" + dir, +

RE: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-09 Thread Nikola Grcevski
e second pair of module-path and module will be +// deemed as application arguments +OutputAnalyzer output = ProcessTools.executeProcess( +createProcessWithLauncherDebugging( +"--module-path=" + dir, +"--module=" + mid, +

RE: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-06 Thread Nikola Grcevski
ontain("argv[ 1] = '--module=" + mid); + +if (IS_WINDOWS) { +output.shouldContain("F--module-path=" + dir).shouldContain("F--module=" + mid); +} + +// java --module=$TESTMODULE/$MAINCLASS --module-path=mods +// This command line wi

RE: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-05 Thread Nikola Grcevski
module usage. Thank you, Nikola -Original Message- From: Henry Jen Sent: December 4, 2019 8:26 PM To: Kumar Srinivasan ; Alan Bateman ; Nikola Grcevski Cc: core-libs-dev@openjdk.java.net Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate > On Dec 4, 2019, at 1:15 PM, Kumar Sri

RE: [EXTERNAL] JDK-8234076 bug fix candidate

2019-12-03 Thread Nikola Grcevski
updated webrev here for your review: https://grcevski.github.io/JDK-8234076/webrev/ Cheers, Nikola -Original Message- From: Henry Jen Sent: December 3, 2019 11:39 AM To: Kumar Srinivasan Cc: Nikola Grcevski ; Alan Bateman ; core-libs-dev@openjdk.java.net Subject: Re: [EXTERNAL] JDK

RE: [EXTERNAL] Re: JDK-8234076 bug fix candidate

2019-12-03 Thread Nikola Grcevski
To: Nikola Grcevski Cc: Henry Jen ; Alan Bateman ; core-libs-dev@openjdk.java.net Subject: Re: [EXTERNAL] Re: JDK-8234076 bug fix candidate Hi, Sorry for chiming in  late in the review process, for what it's worth 1. It is not at all clear to me if this solution is correct, yes it averts

RE: [EXTERNAL] Re: JDK-8234076 bug fix candidate

2019-12-02 Thread Nikola Grcevski
PM To: Alan Bateman Cc: Nikola Grcevski ; core-libs-dev@openjdk.java.net Subject: [EXTERNAL] Re: JDK-8234076 bug fix candidate The fix looks reasonable to me, basically, if the command argument format is not legal, it’s possible we won’t find the main class when doing argument file expansion

JDK-8234076 bug fix candidate

2019-11-20 Thread Nikola Grcevski
Hello core-libs-dev, I'm a VM engineer at Microsoft and new to this mailing list. I took a look at JDK- 8234076 and the root cause is similar to a prior thread on a Windows launcher bug for JDK- 8231863, after the command line arguments are processed, the static variable firstAppArgIndex in