RE: RFR (S) 8232168: Fix non wide char canonicalization on Windows

is in the right file, but that should be a separate discussion. Best regards, Ralf -Original Message- From: David Holmes Sent: Mittwoch, 16. Oktober 2019 05:59 To: Schmelter, Ralf ; hotspot-runtime-...@openjdk.java.net Subject: Re: RFR (S) 8232168: Fix non wide char canonicalization

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi Goetz, thanks for the additional test. Looks good. Best regards, Ralf -Original Message- From: Lindenmaier, Goetz Sent: Montag, 30. September 2019 18:31 To: Schmelter, Ralf ; Hotspot dev runtime ; Java Core Libs Subject: RE: RFR (L, final): 8218626: Add detailed message

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi Goetz, just one thing: >> In NullPointerExceptionTest.java: > > > > It seems you don't have tests for invokeinterface or invokespecial calls to > > cause > > an NPE (e.g. by calling a null interface variable or a private non-static > > method > > of a null objects). > That is because the

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi Goetz, here are my review remarks: In javaClasses.cpp: > #define CLASS_FIELDS_DO(macro) \ > macro(classRedefinedCount_offset, k, "classRedefinedCount", int_signature, > false); \ > macro(_class_loader_offset, k, "classLoader", > classloader_signature, false); \

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Goetz, I've played with the messages a little bit and they generally look good. But I've come across two which look strange: - 'o[static Test.INDEX]' is null. Can not invoke method 'int java.lang.Object.hashCode()' - 'o[The return value of 'int java.lang.String.hashCode()]' is null. Can