On Sat, 14 May 2022 00:30:00 GMT, Tim Prinzing wrote:
> The Class::forName behavior change to match JNI FindClass is a compatible
> change and seems pretty attractive as it would be expected that
> Class::forName would give the same behavior as FindClass which uses the
> system
nced to test for this
> change. Merged master to pick up fixes to unrelated test failures to reduce
> noise.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
append bug id being fixed rather than sorted insert
-
Chang
nced to test for this
> change. Merged master to pick up fixes to unrelated test failures to reduce
> noise.
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains eight commits:
- formatting improvement
- Merge branch 'master
nced to test for this
> change. Merged master to pick up fixes to unrelated test failures to reduce
> noise.
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains six commits:
- Fixed the build of the native c++ test NullCallerTest t
On Sat, 28 May 2022 11:50:19 GMT, Tim Prinzing wrote:
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
> a test module with some resources in it for the actual tests that occur at
> the native level. The native part was switched to c++ instead of
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
On Wed, 1 Jun 2022 02:45:24 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ in
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates a
test module with some resources in it for the actual tests that occur at the
native level. The native part was switched to c++ instead of c to make it
easier to create helper objects that reduce the redundant code
nced to test for this
> change. Merged master to pick up fixes to unrelated test failures to reduce
> noise.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
make javadoc consistent with other caller sensitve methods
-
Chang
nced to test for this
> change. Merged master to pick up fixes to unrelated test failures to reduce
> noise.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Added javadoc comment
-
Changes:
- all: https://git.openjdk.java
On Mon, 16 May 2022 18:55:42 GMT, Mandy Chung wrote:
> `Class::forName(String)` javadoc should specify which class loader to use
> when invoked with null caller similar to the other APIs you fixed for null
> callers.
>
> I think this new test case does not belong to
The Class::forName behavior change to match JNI FindClass is a compatible
change and seems pretty attractive as it would be expected that Class::forName
would give the same behavior as FindClass which uses the system classloader.
The test for 8281006 was enhanced to test for this change.
On Thu, 7 Apr 2022 00:38:07 GMT, Tim Prinzing wrote:
> Created a test called NullCallerGetResource to test
> Module::getResourceAsStream and Class::getResourceAsStream from the native
> level.
>
> At the java level the test builds a test module called 'n' which opens the
; assert(n.getResourceAsStream("closed/test.txt") == null);
>
> The test initially threw an NPE when trying to fetch the open resource. The
> Module class was fixed by removing the fragment with the (caller == null)
> test in getResourceAsStream, and changing the call to isOp
; assert(n.getResourceAsStream("closed/test.txt") == null);
>
> The test initially threw an NPE when trying to fetch the open resource. The
> Module class was fixed by removing the fragment with the (caller == null)
> test in getResourceAsStream, and changing the call to isOp
; assert(n.getResourceAsStream("closed/test.txt") == null);
>
> The test initially threw an NPE when trying to fetch the open resource. The
> Module class was fixed by removing the fragment with the (caller == null)
> test in getResourceAsStream, and changing the call to isOp
On Thu, 7 Apr 2022 05:52:24 GMT, Alan Bateman wrote:
> Tim - this creates a conflict between the spec and implementation, the
> changes to the 2-arg isOpen method need to be dropped so that it continues to
> throw NPE if module is null.
okay
-
PR:
; assert(n.getResourceAsStream("closed/test.txt") == null);
>
> The test initially threw an NPE when trying to fetch the open resource. The
> Module class was fixed by removing the fragment with the (caller == null)
> test in getResourceAsStream, and changing the call to isOp
Created a test called NullCallerGetResource to test Module::getResourceAsStream
and Class::getResourceAsStream from the native level.
At the java level the test builds a test module called 'n' which opens the
package 'open' to everyone. There is also a package 'closed' which is neither
opened
On Wed, 2 Mar 2022 18:56:40 GMT, Tim Prinzing wrote:
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decision o
ion added to the classpath, fetches a string out of the bundle and
> verifies it, and calls clearCache.
>
> The javadoc was updated for the caller sensitive methods changed.
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The
ion added to the classpath, fetches a string out of the bundle and
> verifies it, and calls clearCache.
>
> The javadoc was updated for the caller sensitive methods changed.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 2 Mar 2022 22:21:03 GMT, Mandy Chung wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> suggested changes
>
> test/jdk/java/util/ResourceBundle/exeNullCallerResourceBundle
ion added to the classpath, fetches a string out of the bundle and
> verifies it, and calls clearCache.
>
> The javadoc was updated for the caller sensitive methods changed.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
ion added to the classpath, fetches a string out of the bundle and
> verifies it, and calls clearCache.
>
> The javadoc was updated for the caller sensitive methods changed.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last
The caller class returned by Reflection::getCallerClass was used to gain access
to it's module in most cases and class loader in one case. I added a method to
translate the caller class to caller module so that the decision of what module
represents the caller with no stack frame is made in a
On Fri, 11 Feb 2022 20:36:26 GMT, Tim Prinzing wrote:
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
This pull request has now been integrated.
Changeset: a6f8a386
Author: Tim Prinzing
Committer: Mandy Chung
URL:
https://git.openjdk.ja
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 10 commits:
- Merge master
- fix test breakage from rename
- reformat test s
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix test breakage from rename
-
Changes:
- all: https://git.openjdk.java.n
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote:
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
This pull request has now been integrated.
Changeset: 67763df4
Author: Tim Prinzing
Committer: Mandy Chung
URL:
https://git.openjdk.java.net/jdk/com
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with three additional
commits since the last revision:
- reformat test summary
- reformat test summary
- improve test name and remove experimenta
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix copyright date
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7447/files
- new: ht
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix copyright date
-
Changes:
- all: https://git.openjdk.java.net/jdk/pul
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
More changes from feedback.
The javadoc is improved to reflect InvalidCallerException is
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Changes from feedback.
- Copyright dates fixed
- IllegalCallerException thrown for no
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
remove excess description
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7447/files
-
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
missing dot
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7447/files
- new: ht
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Changes from feedback.
- Improved javadoc.
- Single copyright date in new files.
- Informative str
On Fri, 11 Feb 2022 20:36:26 GMT, Tim Prinzing wrote:
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Yes, I like the IllegalCallerException.
-
PR: https://git.openjdk.java.net/jdk/pull/7448
JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is null
-
Commit messages:
- Merge branch 'master' into JDK-8281000
- JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
null
Changes: https://git.openjdk.java.net/jdk/pull/7448/files
JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
-
Commit messages:
- Merge branch 'master' into JDK-8281003
- Merge branch 'master' into JDK-8281003
- removed commented out code
- Moved null caller MethodHandles.lookup() test to a more reasonable location
-
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote:
> JDK-8276681: Additional malformed Javadoc inline tags in JDK source
This pull request has now been integrated.
Changeset: b8ac0d20
Author: Tim Prinzing
Committer: Lance Andersen
URL:
https://git.openjdk.java.net/jdk/com
> JDK-8276681: Additional malformed Javadoc inline tags in JDK source
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additio
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote:
> JDK-8276674 : Malformed Javadoc inline tags in JDK source
This pull request has now been integrated.
Changeset: 652b5f85
Author: Tim Prinzing
Committer: Brent Christian
URL:
https://git.openjdk.java.net/jdk/com
> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
- Merge branch 'master' into JDK-8276674
- Fixed @code and @link in s
JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream
-
Commit messages:
- Fixed @code and @link in some javadoc for JDK-8276674
Changes: https://git.openjdk.java.net/jdk/pull/6443/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6443=00
Issue:
52 matches
Mail list logo
