Re: FilePermission Canonical path optimization

2015-02-09 Thread deven you
It sounds to me like we need additional means to protect the file permission without canocialization. I am looking forward to seeing the new proposal with appropriate solution for problem Peter raised. Thanks a lot! 2015-02-09 14:50 GMT+08:00 Wang Weijun weijun.w...@oracle.com: On Feb 9,

Re: FilePermission Canonical path optimization

2015-02-08 Thread deven you
. Is there any doc or link for this new proposal? Or if you can update the information for this proposal here, I will be very appreciate! Thanks a lot! 2015-02-09 11:51 GMT+08:00 Wang Weijun weijun.w...@oracle.com: On Feb 9, 2015, at 11:22, deven you ydwch...@gmail.com wrote: Hi Weijun, I see JDK

Re: FilePermission Canonical path optimization

2015-02-08 Thread deven you
: FilePermission makes symlinks useless https://bugs.openjdk.java.net/browse/JDK-4141872 This will be a very big incompatible change and we are still doing a feasibility study. Of course, we won't touch jdk8u or earlier. Thanks Max On Feb 6, 2015, at 14:09, deven you ydwch...@gmail.com

Re: FilePermission Canonical path optimization

2015-02-05 Thread deven you
Hi All, I have updated the patch[1] according to above discussion. Please review it. Thanks a lot [1] http://cr.openjdk.java.net/~youdwei/ojdk-912/webrev.03/ 2015-02-03 16:04 GMT+08:00 Peter Levart peter.lev...@gmail.com: Hi Deven, On 02/03/2015 08:42 AM, deven you wrote: Hi Sean

Re: FilePermission Canonical path optimization

2015-02-02 Thread deven you
Hi Sean, The performance degradation was reported by creating an object with always getting its canonical path and there is no degradation heard after we made the lazy load patch for the canonical path. I have asked related people to give me an env to create this problem so that I can take a

Re: FilePermission Canonical path optimization

2014-12-04 Thread deven you
and this patch will specifically solve the problem for FilePermssion. I will update the patch soon with your suggestion and Wenjian's. Thanks a lot! 2014-12-01 20:50 GMT+08:00 Alan Bateman alan.bate...@oracle.com: On 01/12/2014 08:06, deven you wrote: Hi All, File.getCanonicalPath

Re: FilePermission Canonical path optimization

2014-12-04 Thread deven you
...@oracle.com: Do you need some kind of synchronization on the get_dir_rec() method? --Max On Dec 1, 2014, at 16:06, deven you youd...@linux.vnet.ibm.com wrote: Hi All, File.getCanonicalPath() is a very time-consuming method, we observed significant performance degradation from some

Re: FilePermission Canonical path optimization

2014-12-04 Thread deven you
, this is an optimization for the case a security manager is not present? For the other case, maybe having absolute but not canonical file names is an option? Or maybe have a special optimization for JAVA_HOME prefixed names? Or does it help in that case as well? Gruss Bernd Am 01.12.2014 09:18 schrieb deven

Re: FilePermission Canonical path optimization

2014-12-04 Thread deven you
Hi All, I have updated the patch[3] to reflect all of your suggestions. [3] http://cr.openjdk.java.net/~youdwei/ojdk-912/webrev.02/ Thanks a lot! 2014-12-05 10:39 GMT+08:00 deven you ydwch...@gmail.com: Hi Alan, I am not clear whether canonicalization cache enabled or disabled, however I

FilePermission Canonical path optimization

2014-12-01 Thread deven you
Hi All, File.getCanonicalPath() is a very time-consuming method, we observed significant performance degradation from some application's startup stage with java.io.FilePermission. However, lazying load the calls to getCanonicalPath() from java.ioFilePermission is straightforward and solve this

A question about Depth of container annotations

2014-06-24 Thread deven you
Hi All, I have a question about repeated annotation depth. If this is not the proper mailing list group, please tell me where I should send it to. My question will be about the depth of container annotations. For instance, assume there are 3 annotations. - RepeatedAnn - ContainerAnn -

Re: Non Inherited repeated annotations should not be searched from child Class

2013-06-04 Thread Deven You
Hi All, I didn't see this mail in the mailing list for a long time, so I just comment here to ensure everyone can receive this message. Thanks a lot! On 06/04/2013 09:37 PM, Deven You wrote: Hi All, I have written a test case[1] to show this problem. (If it is confirmed a real bug, I

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2013-01-09 Thread Deven You
23, 2012, at 3:07 AM, Deven You wrote: Hi Lance, Is there any plan for this issue, if any could you update to me? Thanks a lot! On 10/29/2012 06:39 PM, Lance Andersen - Oracle wrote: Hi Deven, I will address the needed updates a bit later. Thank you for your input Best Lance On Oct 29, 2012

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-11-23 Thread Deven You
Hi Lance, Is there any plan for this issue, if any could you update to me? Thanks a lot! On 10/29/2012 06:39 PM, Lance Andersen - Oracle wrote: Hi Deven, I will address the needed updates a bit later. Thank you for your input Best Lance On Oct 29, 2012, at 3:51 AM, Deven You wrote: Hi

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-10-29 Thread Deven You
implementation. Thanks a lot! On 09/21/2012 04:37 PM, Alan Bateman wrote: On 21/09/2012 04:21, Deven You wrote: Hi Lance, I am very busy with other work so I can't work with the SerialBlob/SerialClob item for long time. I am very happy to refine the current test case and create new tests for SerialClob

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-09-20 Thread Deven You
at that time. If you would like to change your test and then create similar tests for SerialClob I will add those as part of the put-back. Again, thank you for your input and time. Best Lance On Jul 5, 2012, at 2:26 AM, Deven You wrote: Hi Lance, Did you review the patch and compare

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-07-05 Thread Deven You
, Thanks for the email and the proposed patch. I will look at this later today or tomorrow. I actually have made these changes in my workspace for JDK 8 but will compare your changes to mine. Best Lance On Jul 2, 2012, at 5:04 AM, Deven You wrote: Hi All, Could anyone notice this problem

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-07-02 Thread Deven You
Hi All, Could anyone notice this problem? Thanks a lot! On 06/25/2012 04:18 PM, Deven You wrote: Hi All, First of all, if the jdbc problem has a better mailing list to post please tell me. I find that javax.sql.rowset.serial.SerialBlob is not fully implemented in OpenJDK 8. Methods

javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-06-25 Thread Deven You
Hi All, First of all, if the jdbc problem has a better mailing list to post please tell me. I find that javax.sql.rowset.serial.SerialBlob is not fully implemented in OpenJDK 8. Methods public InputStream getBinaryStream(long pos,long length) throws SQLException public void

Re: hg: jdk8/tl/jdk: 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled

2012-05-25 Thread Deven You
Hi Alan, Thanks for your reminder, I was going to point that this a manual test case and need someone guide me how to configure it as manual with jtreg. But I missed it by chance. So Masayoshi or someone else, I'd very appreciate if you could guide me how to configure a test case as manual

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-05-17 Thread Deven You
Hi Dmitry, I have verified the change set. Thanks for your commit! On 05/17/2012 03:44 PM, Dmitry Samersoff wrote: Deven, The fix is submitted to openjdk tl workspace http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df33f5f750ec -Dmitry On 2012-04-26 05:21, Deven You wrote: Hi Dmitry

Pass a pointer to JNI_GetCreatedJavaVMs() instead of null

2012-05-07 Thread Deven You
Hi All, There is a potential problem in jdk/src/share/native/com/sun/java/util/jar/pack/jni.cpp. (Maybe it is not suitable for posting this on core-lib, anyone could tell me which mailing list is prefer?) L85: JNI_GetCreatedJavaVMs(vm, 1, null) in which the 3rd parameter is a pointer to

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-25 Thread Deven You
, the changes looks good for me. I'll take care of the rest. We have one more place in Agent.java executing exactly the same code so I'll change both of them on your behalf. -Dmitry On 2012-04-23 11:43, Deven You wrote: Thanks David, So is it ok for you to contribute this patch? On 04/23/2012

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-23 Thread Deven You
to it. Sorry about that. David - On 23/04/2012 4:30 PM, David Holmes wrote: Deven, On 23/04/2012 3:54 PM, Deven You wrote: On 04/18/2012 02:20 PM, Deven You wrote: On 04/18/2012 01:34 PM, Mandy Chung wrote: I think this could still run into CME. System Properties is not a synchronized map

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-22 Thread Deven You
On 04/18/2012 02:20 PM, Deven You wrote: On 04/18/2012 01:34 PM, Mandy Chung wrote: On 4/17/2012 12:33 AM, Deven You wrote: I think this could still run into CME. System Properties is not a synchronized map and the setter methods (System.setProperty or Properties.put method) doesn't

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-18 Thread Deven You
On 04/18/2012 01:34 PM, Mandy Chung wrote: On 4/17/2012 12:33 AM, Deven You wrote: I think this could still run into CME. System Properties is not a synchronized map and the setter methods (System.setProperty or Properties.put method) doesn't synchronize on the Properties object. Hi

Re: core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-17 Thread Deven You
On 04/12/2012 10:09 AM, Mandy Chung wrote: On 4/11/2012 12:36 AM, Deven You wrote: Hi core-libs-devs, I am not sure if sun.management.Agent belongs to jmx-dev mailing list, if so please anyone tell me. serviceability-dev (cc'ed) is the mailing list for this patch. This issue

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-12 Thread Deven You
I have verified this commit. Thanks Alan and Charles! On 04/12/2012 03:12 PM, Charles Lee wrote: On 04/11/2012 03:44 PM, Deven You wrote: On 04/10/2012 04:12 PM, Alan Bateman wrote: On 09/04/2012 10:32, Deven You wrote: : The issue is reported by one of our test team which maintains

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-12 Thread Deven You
. On 04/12/2012 04:26 PM, Alan Bateman wrote: On 12/04/2012 08:22, Deven You wrote: I have verified this commit. Thanks Alan and Charles! The change-set that Charles pushed added test/sun/tools/classpath/ RMICClassPathTest.java but I didn't see it in the original webrev. I see now that your

core-libs-dev sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-11 Thread Deven You
Hi core-libs-devs, I am not sure if sun.management.Agent belongs to jmx-dev mailing list, if so please anyone tell me. This issue is that the sun.management.Agent.loadManagementProperties() will invoke properties.putAll which will throw ConcurrentModifcationException if there are other

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-11 Thread Deven You
On 04/10/2012 04:12 PM, Alan Bateman wrote: On 09/04/2012 10:32, Deven You wrote: : The issue is reported by one of our test team which maintains a set of ORB test cases. Okay but I guess I'm still a bit curious as it's not obvious that rmic (or rmic --iiop) invokes toString, maybe

core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-09 Thread Deven You
Hi core-libs-devs, There are 2 sun bugs related to this issue: http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6695325^and http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6610897^ The basic problem is that the new

Re: core-libs-dev New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

2012-04-09 Thread Deven You
On 04/09/2012 05:03 PM, Alan Bateman wrote: On 09/04/2012 08:01, Deven You wrote: Hi core-libs-devs, There are 2 sun bugs related to this issue: http://bugs.sun.com/view_bug.do;jsessionid=663548580556ae43f50bf92c75b5?bug_id=6695325^and http://bugs.sun.com/view_bug.do;jsessionid