Withdrawn: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-26 Thread wxiang
On Tue, 31 Aug 2021 12:11:46 GMT, wxiang wrote: > Using jarIndex for Hibench, there is an unexpected behavior with the > exception "Exception in thread "main" > org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme > "hdfs"".

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-26 Thread wxiang
On Tue, 31 Aug 2021 12:11:46 GMT, wxiang wrote: > Using jarIndex for Hibench, there is an unexpected behavior with the > exception "Exception in thread "main" > org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme > "hdfs"".

Withdrawn: 8273401: Remove JarIndex support in URLClassPath

2021-09-26 Thread wxiang
On Tue, 7 Sep 2021 03:34:27 GMT, wxiang wrote: > There is a bug for URLClassPath.findResources with JarIndex. > With some discussions about the bug, the current priority is to remove the > JAR index support in URLClassPath, > and don’t need to do anything to the jar tool in th

Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-26 Thread wxiang
On Wed, 8 Sep 2021 06:22:38 GMT, wxiang wrote: >> There is a bug for URLClassPath.findResources with JarIndex. >> With some discussions about the bug, the current priority is to remove the >> JAR index support in URLClassPath, >> and don’t need to do anything to the ja

Integrated: 8273401: Disable JarIndex support in URLClassPath

2021-09-26 Thread wxiang
On Wed, 15 Sep 2021 09:33:10 GMT, wxiang wrote: > There is a bug for URLClassPath.findResources with JarIndex. > Currently, there was agreement on dropping the support from the > URLClassLoader implementation but it was suggested that it should be disabled > for a release o

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-23 Thread wxiang
On Thu, 16 Sep 2021 01:29:41 GMT, wxiang wrote: >> wxiang has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add isEmpty check > > I have changed > > ENABLE_JAR_INDEX = p != null ? p.equals("true

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-16 Thread wxiang
On Thu, 16 Sep 2021 11:08:17 GMT, Alan Bateman wrote: >> wxiang has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add isEmpty check > > src/java.base/share/classes/jdk/internal/loader/URLClas

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v3]

2021-09-16 Thread wxiang
rty can be used to re-enable JarIndex support in URLClassPath. > > The PR includes: > Disable JarIndex support in URLClassPath by default. > Add system property jdk.net.URLClassPath.enableJarIndex to re-enable JarIndex > support. wxiang has updated the pull request incrementally wit

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-16 Thread wxiang
On Thu, 16 Sep 2021 09:15:34 GMT, Daniel Fuchs wrote: >> I can appreciate that and that is a fair point. I guess where I was >> coming from was that the property is temporary and has to be explicitly >> specified so ignoring the value seemed worth raising/discussing. >> >> Assuming the

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-15 Thread wxiang
On Thu, 16 Sep 2021 01:29:12 GMT, wxiang wrote: >> There is a bug for URLClassPath.findResources with JarIndex. >> Currently, there was agreement on dropping the support from the >> URLClassLoader implementation but it was suggested that it should be >> disabled for

Re: RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

2021-09-15 Thread wxiang
rty can be used to re-enable JarIndex support in URLClassPath. > > The PR includes: > Disable JarIndex support in URLClassPath by default. > Add system property jdk.net.URLClassPath.enableJarIndex to re-enable JarIndex > support. wxiang has updated the pull request incrementally wit

Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-15 Thread wxiang
On Wed, 15 Sep 2021 05:59:13 GMT, Alan Bateman wrote: > > Yes, I will take care of it. Need I create a new PR? > > Up to you, it's okay to continue with this one if you want, we would just > need to change the description here and in JBS. I created a new PR

RFR: 8273401: Disable JarIndex support in URLClassPath

2021-09-15 Thread wxiang
There is a bug for URLClassPath.findResources with JarIndex. Currently, there was agreement on dropping the support from the URLClassLoader implementation but it was suggested that it should be disabled for a release or two before the code is removed. A system property can be used to re-enable

Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-14 Thread wxiang
On Wed, 8 Sep 2021 06:30:34 GMT, wxiang wrote: >> wxiang has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Some minor changes >> >> Include: >> 1. remove public for INDEX_NAME

Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-08 Thread wxiang
On Wed, 8 Sep 2021 06:22:38 GMT, wxiang wrote: >> There is a bug for URLClassPath.findResources with JarIndex. >> With some discussions about the bug, the current priority is to remove the >> JAR index support in URLClassPath, >> and don’t need to do anything to the ja

Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-08 Thread wxiang
On Tue, 7 Sep 2021 17:39:20 GMT, Sean Mullan wrote: >> src/java.base/share/classes/java/util/jar/JarVerifier.java line 147: >> >>> 145: >>> 146: if (uname.equals(JarFile.MANIFEST_NAME) || >>> 147: uname.equals(JarFile.INDEX_NAME)) { >> >> It would be

Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-08 Thread wxiang
the jdk.jartool module. > > The PR includes: > 1. remove the JarIndex support in URLClassPath > 2. move JarIndex into jdk.jartool module. wxiang has updated the pull request incrementally with one additional commit since the last revision: Some minor changes Include: 1. r

Re: RFR: 8273401: Remove JarIndex support in URLClassPath [v2]

2021-09-08 Thread wxiang
On Tue, 7 Sep 2021 10:39:01 GMT, Lance Andersen wrote: >> src/java.base/share/classes/java/util/jar/JarFile.java line 220: >> >>> 218: * The index file name. >>> 219: */ >>> 220: public static final String INDEX_NAME = "META-INF/INDEX.LIST"; >> >> Adding this as a public field

RFR: 8273401: Remove JarIndex support in URLClassPath

2021-09-06 Thread wxiang
There is a bug for URLClassPath.findResources with JarIndex. With some discussions about the bug, the current priority is to remove the JAR index support in URLClassPath, and don’t need to do anything to the jar tool in the short term, except just to move JarIndex to the jdk.jartool module.

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-06 Thread wxiang
On Tue, 31 Aug 2021 12:11:46 GMT, wxiang wrote: > Using jarIndex for Hibench, there is an unexpected behavior with the > exception "Exception in thread "main" > org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme > "hdfs"".

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-03 Thread wxiang
On Fri, 3 Sep 2021 10:48:01 GMT, Alan Bateman wrote: > > @AlanBateman Sure, I am interested in it. > > Great! I think there are several parts to this. The removal of the JAR index > support from the URLClassLoader implementation, the `jar i` option, the JAR > file spec, and the jar tool man

Re: RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-09-03 Thread wxiang
} >> return false; >> } >> } >> ... >> }; >> } >> >> With the JarIndex, there is only one loader which is corresponding to the >> jar with the index due to the implementat

RFR: 6957241: ClassLoader.getResources() returns only 1 instance when using jar indexing

2021-08-31 Thread wxiang
Using jarIndex for Hibench, there is an unexpected behavior with the exception "Exception in thread "main" org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme "hdfs"". After investigating it, it is related to the usage of ServiceLoader with JarIndex. The below stack