Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles
Hi Jane, On 20/08/2014 7:03 PM, Evgeniya Stepanova wrote: Update review request with links: bug: https://bugs.openjdk.java.net/browse/JDK-8055393 webrev:http://cr.openjdk.java.net/~avstepan/eistepan/8055393/webrev.00/ http://cr.openjdk.java.net/%7Eavstepan/eistepan/8055393/webrev.00/ To be able to evaluate this it would be useful to know what the dependencies are that force these tests into specific groups. I don't see why you have removed sun/misc/URLClassPath/ClassnameCharTest.java from needs_compact2 - but as far as I can see it should be in needs_jre because it accesses sun.applet.AppletClassLoader! Thanks, David Thanks, Jane On 19.08.2014 17:03, Evgeniya Stepanova wrote: Re-added lost diff On 19.08.2014 16:58, Evgeniya Stepanova wrote: Hi all, Could you please review fix for 8055393 Problem:Some tests are being executed and fail under profiles Solution: -test java/lang/ProcessBuilder/InheritIO/InheritIO.sh changed to use COMPILEJAVA (set by jtreg harness) javac instead of TESTJAVA (which is absent in profiles) -java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java and some of the java/util/logging/ tests use java.lang.management.ManagementFactory class to get deadlocked threads. Such tests are added to the needs_compact3 testgroup -test java/lang/invoke/lambda/LambdaAsm.java check bytecode generation and use javac classes. Added to needs_jdk testgroup -test java/net/Authenticator/B4769350.java uses com.sun.net.httpserver.HttpHandler class as base class for all testcases. Added to the needs_compact2 testgroup -Some of the javax/management/mxbean tests uses java.beans.ConstructorProperties annotation. Such tests are added to the needs_jre test group -test sun/misc/URLClassPath/ClassnameCharTest.java included in both needs_compact2 and needs_jre testgroups. Removed from needs_compact2 testgroup since it fails on compacts2-3 Testing: locally. Tests excluded as expected In attachement diff against jdk8u-dev repo
Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles
Hi David! sun/misc/URLClassPath/ClassnameCharTest.java was in both needs_compact2 and needs_jre testgroups. I just removed it from needs_compact2 testgroup because I've noticed that for the cleanup reason. As for tests dependencies, it were described in the very first message (please see below). I'll be very grateful if you review them for checking. Thanks, Jane On 21.08.2014 14:22, David Holmes wrote: Hi Jane, On 20/08/2014 7:03 PM, Evgeniya Stepanova wrote: Update review request with links: bug: https://bugs.openjdk.java.net/browse/JDK-8055393 webrev:http://cr.openjdk.java.net/~avstepan/eistepan/8055393/webrev.00/ http://cr.openjdk.java.net/%7Eavstepan/eistepan/8055393/webrev.00/ To be able to evaluate this it would be useful to know what the dependencies are that force these tests into specific groups. I don't see why you have removed sun/misc/URLClassPath/ClassnameCharTest.java from needs_compact2 - but as far as I can see it should be in needs_jre because it accesses sun.applet.AppletClassLoader! Thanks, David Thanks, Jane On 19.08.2014 17:03, Evgeniya Stepanova wrote: Re-added lost diff On 19.08.2014 16:58, Evgeniya Stepanova wrote: Hi all, Could you please review fix for 8055393 Problem:Some tests are being executed and fail under profiles Solution: -test java/lang/ProcessBuilder/InheritIO/InheritIO.sh changed to use COMPILEJAVA (set by jtreg harness) javac instead of TESTJAVA (which is absent in profiles) -java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java and some of the java/util/logging/ tests use java.lang.management.ManagementFactory class to get deadlocked threads. Such tests are added to the needs_compact3 testgroup -test java/lang/invoke/lambda/LambdaAsm.java check bytecode generation and use javac classes. Added to needs_jdk testgroup -test java/net/Authenticator/B4769350.java uses com.sun.net.httpserver.HttpHandler class as base class for all testcases. Added to the needs_compact2 testgroup -Some of the javax/management/mxbean tests uses java.beans.ConstructorProperties annotation. Such tests are added to the needs_jre test group -test sun/misc/URLClassPath/ClassnameCharTest.java included in both needs_compact2 and needs_jre testgroups. Removed from needs_compact2 testgroup since it fails on compacts2-3 Testing: locally. Tests excluded as expected In attachement diff against jdk8u-dev repo -- /Evgeniya Stepanova/
Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles
On 21/08/2014 8:35 PM, Evgeniya Stepanova wrote: Hi David! sun/misc/URLClassPath/ClassnameCharTest.java was in both needs_compact2 and needs_jre testgroups. I just removed it from needs_compact2 testgroup because I've noticed that for the cleanup reason. As for tests dependencies, it were described in the very first message Sorry - my bad! Don't know how I didn't see all that info there. (please see below). I'll be very grateful if you review them for checking. Reviewed. Thanks, David Thanks, Jane On 21.08.2014 14:22, David Holmes wrote: Hi Jane, On 20/08/2014 7:03 PM, Evgeniya Stepanova wrote: Update review request with links: bug: https://bugs.openjdk.java.net/browse/JDK-8055393 webrev:http://cr.openjdk.java.net/~avstepan/eistepan/8055393/webrev.00/ http://cr.openjdk.java.net/%7Eavstepan/eistepan/8055393/webrev.00/ To be able to evaluate this it would be useful to know what the dependencies are that force these tests into specific groups. I don't see why you have removed sun/misc/URLClassPath/ClassnameCharTest.java from needs_compact2 - but as far as I can see it should be in needs_jre because it accesses sun.applet.AppletClassLoader! Thanks, David Thanks, Jane On 19.08.2014 17:03, Evgeniya Stepanova wrote: Re-added lost diff On 19.08.2014 16:58, Evgeniya Stepanova wrote: Hi all, Could you please review fix for 8055393 Problem:Some tests are being executed and fail under profiles Solution: -test java/lang/ProcessBuilder/InheritIO/InheritIO.sh changed to use COMPILEJAVA (set by jtreg harness) javac instead of TESTJAVA (which is absent in profiles) -java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java and some of the java/util/logging/ tests use java.lang.management.ManagementFactory class to get deadlocked threads. Such tests are added to the needs_compact3 testgroup -test java/lang/invoke/lambda/LambdaAsm.java check bytecode generation and use javac classes. Added to needs_jdk testgroup -test java/net/Authenticator/B4769350.java uses com.sun.net.httpserver.HttpHandler class as base class for all testcases. Added to the needs_compact2 testgroup -Some of the javax/management/mxbean tests uses java.beans.ConstructorProperties annotation. Such tests are added to the needs_jre test group -test sun/misc/URLClassPath/ClassnameCharTest.java included in both needs_compact2 and needs_jre testgroups. Removed from needs_compact2 testgroup since it fails on compacts2-3 Testing: locally. Tests excluded as expected In attachement diff against jdk8u-dev repo -- /Evgeniya Stepanova/
Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles
Update review request with links: bug: https://bugs.openjdk.java.net/browse/JDK-8055393 webrev:http://cr.openjdk.java.net/~avstepan/eistepan/8055393/webrev.00/ http://cr.openjdk.java.net/%7Eavstepan/eistepan/8055393/webrev.00/ Thanks, Jane On 19.08.2014 17:03, Evgeniya Stepanova wrote: Re-added lost diff On 19.08.2014 16:58, Evgeniya Stepanova wrote: Hi all, Could you please review fix for 8055393 Problem:Some tests are being executed and fail under profiles Solution: -test java/lang/ProcessBuilder/InheritIO/InheritIO.sh changed to use COMPILEJAVA (set by jtreg harness) javac instead of TESTJAVA (which is absent in profiles) -java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java and some of the java/util/logging/ tests use java.lang.management.ManagementFactory class to get deadlocked threads. Such tests are added to the needs_compact3 testgroup -test java/lang/invoke/lambda/LambdaAsm.java check bytecode generation and use javac classes. Added to needs_jdk testgroup -test java/net/Authenticator/B4769350.java uses com.sun.net.httpserver.HttpHandler class as base class for all testcases. Added to the needs_compact2 testgroup -Some of the javax/management/mxbean tests uses java.beans.ConstructorProperties annotation. Such tests are added to the needs_jre test group -test sun/misc/URLClassPath/ClassnameCharTest.java included in both needs_compact2 and needs_jre testgroups. Removed from needs_compact2 testgroup since it fails on compacts2-3 Testing: locally. Tests excluded as expected In attachement diff against jdk8u-dev repo -- /Evgeniya Stepanova/
Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles
On 8/20/2014 2:03 AM, Evgeniya Stepanova wrote: Update review request with links: bug: https://bugs.openjdk.java.net/browse/JDK-8055393 webrev:http://cr.openjdk.java.net/~avstepan/eistepan/8055393/webrev.00/ http://cr.openjdk.java.net/%7Eavstepan/eistepan/8055393/webrev.00/ Looks okay to me. Mandy
8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles
Hi all, Could you please review fix for 8055393 Problem:Some tests are being executed and fail under profiles Solution: -test java/lang/ProcessBuilder/InheritIO/InheritIO.sh changed to use COMPILEJAVA (set by jtreg harness) javac instead of TESTJAVA (which is absent in profiles) -java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java and some of the java/util/logging/ tests use java.lang.management.ManagementFactory class to get deadlocked threads. Such tests are added to the needs_compact3 testgroup -test java/lang/invoke/lambda/LambdaAsm.java check bytecode generation and use javac classes. Added to needs_jdk testgroup -test java/net/Authenticator/B4769350.java uses com.sun.net.httpserver.HttpHandler class as base class for all testcases. Added to the needs_compact2 testgroup -Some of the javax/management/mxbean tests uses java.beans.ConstructorProperties annotation. Such tests are added to the needs_jre test group -test sun/misc/URLClassPath/ClassnameCharTest.java included in both needs_compact2 and needs_jre testgroups. Removed from needs_compact2 testgroup since it fails on compacts2-3 Testing: locally. Tests excluded as expected In attachement diff against jdk8u-dev repo
Re: 8055393: Some tests added to the TEST.group to exclude execution on inappropriate compact profiles
Re-added lost diff
On 19.08.2014 16:58, Evgeniya Stepanova wrote:
Hi all,
Could you please review fix for 8055393
Problem:Some tests are being executed and fail under profiles
Solution:
-test java/lang/ProcessBuilder/InheritIO/InheritIO.sh changed to use
COMPILEJAVA (set by jtreg harness) javac instead of TESTJAVA (which is absent
in profiles)
-java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java and some
of the java/util/logging/ tests use java.lang.management.ManagementFactory
class to get deadlocked threads. Such tests are added to the needs_compact3
testgroup
-test java/lang/invoke/lambda/LambdaAsm.java check bytecode generation and use
javac classes. Added to needs_jdk testgroup
-test java/net/Authenticator/B4769350.java uses
com.sun.net.httpserver.HttpHandler class as base class for all testcases. Added
to the needs_compact2 testgroup
-Some of the javax/management/mxbean tests uses
java.beans.ConstructorProperties annotation. Such tests are added to the
needs_jre test group
-test sun/misc/URLClassPath/ClassnameCharTest.java included in both
needs_compact2 and needs_jre testgroups. Removed from needs_compact2 testgroup
since it fails on compacts2-3
Testing: locally. Tests excluded as expected
In attachement diff against jdk8u-dev repo
--
/Evgeniya Stepanova/
diff -r 3b5417813053 test/TEST.groups
--- a/test/TEST.groups Thu Aug 14 15:18:11 2014 +0200
+++ b/test/TEST.groups Tue Aug 19 16:06:07 2014 +0400
@@ -314,6 +314,7 @@
java/io/Serializable/serialver \
java/lang/invoke/lambda/LambdaAccessControlDoPrivilegedTest.java \
java/lang/invoke/lambda/LambdaAccessControlTest.java \
+ java/lang/invoke/lambda/LambdaAsm.java \
java/lang/System/MacEncoding/TestFileEncoding.java \
java/net/URLClassLoader/closetest/GetResourceAsStream.java \
java/util/Collections/EmptyIterator.java \
@@ -370,8 +371,12 @@
java/text/Bidi/Bug7051769.java \
javax/crypto/Cipher/CipherStreamClose.java \
javax/management/monitor/AttributeArbitraryDataTypeTest.java \
- jdk/lambda/vm/InterfaceAccessFlagsTest.java \
- sun/misc/URLClassPath/ClassnameCharTest.java
+ javax/management/mxbean/AmbiguousConstructorTest.java \
+ javax/management/mxbean/ExceptionDiagnosisTest.java \
+ javax/management/mxbean/LeakTest.java \
+ javax/management/mxbean/MXBeanTest.java \
+ javax/management/mxbean/PropertyNamesTest.java \
+ jdk/lambda/vm/InterfaceAccessFlagsTest.java
# Tests dependent on the optional charsets.jar
# These are isolated for easy exclusions
@@ -465,6 +470,7 @@
sun/security/acl \
sun/security/jgss \
sun/security/krb5 \
+ java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java \
java/lang/System/MacEncoding/TestFileEncoding.java \
java/nio/channels/AsynchronousSocketChannel/Leaky.java \
java/security/PermissionCollection/Concurrent.java \
@@ -472,6 +478,8 @@
java/security/cert/GetInstance.java \
java/util/logging/DrainFindDeadlockTest.java \
java/util/logging/LoggingMXBeanTest.java \
+ java/util/logging/TestLogConfigurationDeadLock.java \
+ java/util/logging/TestLoggerBundleSync.java \
sun/net/www/http/KeepAliveCache/B5045306.java \
sun/security/provider/PolicyFile/Alias.java \
sun/security/provider/PolicyFile/Comparator.java \
@@ -523,6 +531,7 @@
java/lang/PrimitiveSumMinMaxTest.java \
java/lang/String/StringJoinTest.java \
java/lang/Thread/StopThrowable.java \
+ java/net/Authenticator/B4769350.java \
java/net/Authenticator/Deadlock.java \
java/net/CookieHandler/LocalHostCookie.java \
java/net/CookieHandler/CookieManagerTest.java \
diff -r 3b5417813053 test/java/lang/ProcessBuilder/InheritIO/InheritIO.sh
--- a/test/java/lang/ProcessBuilder/InheritIO/InheritIO.sh Thu Aug 14
15:18:11 2014 +0200
+++ b/test/java/lang/ProcessBuilder/InheritIO/InheritIO.sh Tue Aug 19
16:06:07 2014 +0400
@@ -36,9 +36,12 @@
exit 1
fi
+if [ x${COMPILEJAVA} = x ]; then
+ COMPILEJAVA=${TESTJAVA}
+fi
JAVA=${TESTJAVA}/bin/java
-JAVAC=${TESTJAVA}/bin/javac
+JAVAC=${COMPILEJAVA}/bin/javac
cp -f ${TESTSRC}/InheritIO.java .
