--Original Message-
From: Stuart Marks
Sent: Tuesday, April 17, 2018 5:11 AM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: core-libs-dev <core-libs-dev@openjdk.java.net>; Paul Sandoz
<paul.san...@oracle.com>
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi
Theeyarath <vivek.theeyar...@oracle.com>
Cc: core-libs-dev <core-libs-dev@openjdk.java.net>; Paul Sandoz
<paul.san...@oracle.com>
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek,
Thanks for the update. In the test files, please remove the unnecessar
-libs-dev@openjdk.java.net>; Paul Sandoz
<paul.san...@oracle.com>
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek,
Thanks for the update. In the test files, please remove the unnecessary imports
of List and the various Predicate types. In most cases it's not a problem to
have unne
: Stuart Marks
Sent: Tuesday, April 17, 2018 5:11 AM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: core-libs-dev <core-libs-dev@openjdk.java.net>; Paul Sandoz
<paul.san...@oracle.com>
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek,
Please add "@since 11&qu
-libs-dev@openjdk.java.net>; Paul Sandoz
<paul.san...@oracle.com>
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek,
Please add "@since 11" tags to the doc comments of the four Optional*.isEmpty()
methods.
Regarding the tests, I don't think the various newly added tes
; core-libs-dev
<core-libs-dev@openjdk.java.net>
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
On 15 Apr 2018, at 11:25, Vivek Theeyarath <vivek.theeyar...@oracle.com> wrote:
Hi All,
Please review http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.01/
This looks o
, 2018 6:48 PM
To: Vivek Theeyarath <vivek.theeyar...@oracle.com>
Cc: Remi Forax <fo...@univ-mlv.fr>; core-libs-dev
<core-libs-dev@openjdk.java.net>
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
> On 15 Apr 2018, at 11:25, Vivek Theeyarath <vivek.theeyar...@oracl
OptionalInt.
-Chris.
> Regards
> Vivek
> -Original Message-
> From: Vivek Theeyarath
> Sent: Saturday, April 14, 2018 6:24 PM
> To: Remi Forax <fo...@univ-mlv.fr>
> Cc: core-libs-dev <core-libs-dev@openjdk.java.net>
> Subject: RE: RFR: 8184693: (
i Forax" <fo...@univ-mlv.fr>, "core-libs-dev"
> <core-libs-dev@openjdk.java.net>
> Envoyé: Dimanche 15 Avril 2018 12:25:09
> Objet: RE: RFR: 8184693: (opt) add Optional.isEmpty
> Hi All,
> Please review http://cr.openjdk.java.net/~vtheeyarath/818469
@oracle.com>
Cc: core-libs-dev <core-libs-dev@openjdk.java.net>
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek,
OptionalInt, OptionalLong and OptionalDouble should be changed too.
Rémi
- Mail original -
> De: "Vivek Theeyarath" <vivek.theeyar...@ora
-libs-dev@openjdk.java.net>
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek,
OptionalInt, OptionalLong and OptionalDouble should be changed too.
Rémi
- Mail original -
> De: "Vivek Theeyarath" <vivek.theeyar...@oracle.com>
> À: "core-libs-dev&quo
Hi Vivek,
the parenthesis around the lambdas in Basic.java are unnecessary
Predicate isPositiveNumber = (x -> x > 0);
vs
Predicate isPositiveNumber = x -> x > 0;
the same remark for isNegativeNumber.
cheers,
Rémi
- Mail original -
> De: "Vivek Theeyarath"
Hi Vivek,
OptionalInt, OptionalLong and OptionalDouble should be changed too.
Rémi
- Mail original -
> De: "Vivek Theeyarath"
> À: "core-libs-dev"
> Envoyé: Samedi 14 Avril 2018 08:22:50
> Objet: RFR: 8184693: (opt) add
13 matches
Mail list logo