Re: RFR: 8022749: Convert junit tests to testng in test/java/lang/invoke
Thanks for the heads up. I noticed this just now; after refreshing my repos half of the tests fail. Where is the doc that says how to run jtreg and ant (Netbeans) now that my tests have been changed for me? — John On Aug 12, 2013, at 2:17 AM, Alan Bateman alan.bate...@oracle.com wrote: On 10/08/2013 01:25, Henry Jen wrote: Hi, Please review a webrev contributed by Mani Sarkar that converts junit tests in test/java/lang/invoke to testng. http://cr.openjdk.java.net/~henryjen/tl/8022749/0/webrev/ Cheers, Henry This looks good to me (but cc'ing mlvm-dev so that John/Christian/others that might run these tests interactively are aware of this). -Alan. ___ mlvm-dev mailing list mlvm-...@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
Re: RFR: 8022749: Convert junit tests to testng in test/java/lang/invoke
On 10/08/2013 01:25, Henry Jen wrote: Hi, Please review a webrev contributed by Mani Sarkar that converts junit tests in test/java/lang/invoke to testng. http://cr.openjdk.java.net/~henryjen/tl/8022749/0/webrev/ Cheers, Henry This looks good to me (but cc'ing mlvm-dev so that John/Christian/others that might run these tests interactively are aware of this). -Alan.
RFR: 8022749: Convert junit tests to testng in test/java/lang/invoke
Hi, Please review a webrev contributed by Mani Sarkar that converts junit tests in test/java/lang/invoke to testng. http://cr.openjdk.java.net/~henryjen/tl/8022749/0/webrev/ Cheers, Henry
Re: RFR: 8022749: Convert junit tests to testng in test/java/lang/invoke
Looks good to me. Nice cleanup Mani and thank you for sponsoring the change Henry! Mike On Aug 9 2013, at 17:25 , Henry Jen wrote: Hi, Please review a webrev contributed by Mani Sarkar that converts junit tests in test/java/lang/invoke to testng. http://cr.openjdk.java.net/~henryjen/tl/8022749/0/webrev/ Cheers, Henry