Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables [v2]

2022-03-30 Thread Naoto Sato 
On Wed, 30 Mar 2022 00:46:49 GMT, Joe Wang  wrote:

>> Resets state of a Catalog instance on each matching call so that it can be 
>> reused. Adjusts CatalogResolver's resolve routine so that it continues to 
>> observes the PREFER feature in a resolution process. Without the adjustment, 
>> PreferFeatureTest would fail.
>> 
>> Mach5 XML tests passed: 
>> https://mach5.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542
>
> Joe Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   remove variable, check instance instead.

Marked as reviewed by naoto (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8018

Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables [v2]

2022-03-29 Thread Joe Wang 
On Tue, 29 Mar 2022 21:41:52 GMT, Naoto Sato  wrote:

>> Joe Wang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   remove variable, check instance instead.
>
> src/java.xml/share/classes/javax/xml/catalog/GroupEntry.java line 44:
> 
>> 42: 
>> 43: //Indicates whether this is the Catalog instance (vs a Catalog entry)
>> 44: boolean isCatalogInstance = false;
> 
> Can we eliminate this instance variable, by checking whether the type is 
> `Catalog` or not in `resetOnStart()`?

Yes, thanks!

-

PR: https://git.openjdk.java.net/jdk/pull/8018

Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables [v2]

2022-03-29 Thread Joe Wang 
> Resets state of a Catalog instance on each matching call so that it can be 
> reused. Adjusts CatalogResolver's resolve routine so that it continues to 
> observes the PREFER feature in a resolution process. Without the adjustment, 
> PreferFeatureTest would fail.
> 
> Mach5 XML tests passed: 
> https://mach5.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542

Joe Wang has updated the pull request incrementally with one additional commit 
since the last revision:

  remove variable, check instance instead.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8018/files
  - new: https://git.openjdk.java.net/jdk/pull/8018/files/14513d7b..16bebbcf

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8018=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8018=00-01

  Stats: 6 lines in 2 files changed: 0 ins; 5 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8018.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8018/head:pull/8018

PR: https://git.openjdk.java.net/jdk/pull/8018

Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables

2022-03-29 Thread Naoto Sato 
On Tue, 29 Mar 2022 16:39:50 GMT, Joe Wang  wrote:

> Resets state of a Catalog instance on each matching call so that it can be 
> reused. Adjusts CatalogResolver's resolve routine so that it continues to 
> observes the PREFER feature in a resolution process. Without the adjustment, 
> PreferFeatureTest would fail.
> 
> Mach5 XML tests passed: 
> https://mach5.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542

src/java.xml/share/classes/javax/xml/catalog/GroupEntry.java line 44:

> 42: 
> 43: //Indicates whether this is the Catalog instance (vs a Catalog entry)
> 44: boolean isCatalogInstance = false;

Can we eliminate this instance variable, by checking whether the type is 
`Catalog` or not in `resetOnStart()`?

-

PR: https://git.openjdk.java.net/jdk/pull/8018

Re: RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables

2022-03-29 Thread Lance Andersen 
On Tue, 29 Mar 2022 16:39:50 GMT, Joe Wang  wrote:

> Resets state of a Catalog instance on each matching call so that it can be 
> reused. Adjusts CatalogResolver's resolve routine so that it continues to 
> observes the PREFER feature in a resolution process. Without the adjustment, 
> PreferFeatureTest would fail.
> 
> Mach5 XML tests passed: 
> https://mach5.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542

looks fine Joe

-

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8018

RFR: 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset state variables

2022-03-29 Thread Joe Wang 
Resets state of a Catalog instance on each matching call so that it can be 
reused. Adjusts CatalogResolver's resolve routine so that it continues to 
observes the PREFER feature in a resolution process. Without the adjustment, 
PreferFeatureTest would fail.

Mach5 XML tests passed: 
https://mach5.us.oracle.com/mdash/jobs/huizwang-open-20220329-0148-30563542

-

Commit messages:
 - 8253569: javax.xml.catalog.Catalog.matchURI() implementation should reset 
state variables

Changes: https://git.openjdk.java.net/jdk/pull/8018/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8018=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8253569
  Stats: 220 lines in 5 files changed: 198 ins; 18 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8018.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8018/head:pull/8018

PR: https://git.openjdk.java.net/jdk/pull/8018