Re: RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException
On 4/14/15 12:10 AM, Alan Bateman wrote: On 13/04/2015 23:49, Brent Christian wrote: Hello, Please review this small javadoc change. It was discovered that some codePoint-related methods in StringBuffer are missing documentation for throwing IndexOutOfBoundsException. The methods are: codePointAt(int) codePointBefore(int) codePointCount(int,int) offsetByCodePoints(int,int) The StringBuilder JavaDoc does have @throws tags for those methods. This looks okay. Do you have cycles to check if there are any more of these? It seems that every few years we find more cases where we have missed the inheritDoc. I'll see if I can find some time to check around. Thanks, -Brent
Re: RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException
On 13/04/2015 23:49, Brent Christian wrote: Hello, Please review this small javadoc change. It was discovered that some codePoint-related methods in StringBuffer are missing documentation for throwing IndexOutOfBoundsException. The methods are: codePointAt(int) codePointBefore(int) codePointCount(int,int) offsetByCodePoints(int,int) The StringBuilder JavaDoc does have @throws tags for those methods. This looks okay. Do you have cycles to check if there are any more of these? It seems that every few years we find more cases where we have missed the inheritDoc. -Alan
RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException
Hello, Please review this small javadoc change. It was discovered that some codePoint-related methods in StringBuffer are missing documentation for throwing IndexOutOfBoundsException. The methods are: codePointAt(int) codePointBefore(int) codePointCount(int,int) offsetByCodePoints(int,int) The StringBuilder JavaDoc does have @throws tags for those methods. Bug: https://bugs.openjdk.java.net/browse/JDK-8048264 Webrev+specdiff: http://cr.openjdk.java.net/~bchristi/8048264/webrev.0/ Thanks, -Brent
Re: RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException
Let me know and I will add myself as a reviewer Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 13, 2015, at 6:55 PM, Brent Christian brent.christ...@oracle.com wrote: Thanks, Lance. My next stop is the CCC. :) -Brent On 4/13/15 3:53 PM, Lance @ Oracle wrote: Hi Brent, This looks fine You might need to fast track a CCC request even though this is minor Best Lance http://oracle.com/us/design/oracle-email-sig-198324.gifLance Andersen| Principal Member of Technical Staff | +1.781.442.2037 tel:+1.781.442.2037 Oracle Java Engineering 1 Network Drive x-apple-data-detectors://34/0 Burlington, MA 01803 x-apple-data-detectors://34/0 lance.ander...@oracle.com mailto:lance.ander...@oracle.com Sent from my iPad On Apr 13, 2015, at 6:49 PM, Brent Christian brent.christ...@oracle.com mailto:brent.christ...@oracle.com wrote: Hello, Please review this small javadoc change. It was discovered that some codePoint-related methods in StringBuffer are missing documentation for throwing IndexOutOfBoundsException. The methods are: codePointAt(int) codePointBefore(int) codePointCount(int,int) offsetByCodePoints(int,int) The StringBuilder JavaDoc does have @throws tags for those methods. Bug: https://bugs.openjdk.java.net/browse/JDK-8048264 Webrev+specdiff: http://cr.openjdk.java.net/~bchristi/8048264/webrev.0/ Thanks, -Brent
Re: RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException
Thanks, Lance. My next stop is the CCC. :) -Brent On 4/13/15 3:53 PM, Lance @ Oracle wrote: Hi Brent, This looks fine You might need to fast track a CCC request even though this is minor Best Lance http://oracle.com/us/design/oracle-email-sig-198324.gifLance Andersen| Principal Member of Technical Staff | +1.781.442.2037 tel:+1.781.442.2037 Oracle Java Engineering 1 Network Drive x-apple-data-detectors://34/0 Burlington, MA 01803 x-apple-data-detectors://34/0 lance.ander...@oracle.com mailto:lance.ander...@oracle.com Sent from my iPad On Apr 13, 2015, at 6:49 PM, Brent Christian brent.christ...@oracle.com mailto:brent.christ...@oracle.com wrote: Hello, Please review this small javadoc change. It was discovered that some codePoint-related methods in StringBuffer are missing documentation for throwing IndexOutOfBoundsException. The methods are: codePointAt(int) codePointBefore(int) codePointCount(int,int) offsetByCodePoints(int,int) The StringBuilder JavaDoc does have @throws tags for those methods. Bug: https://bugs.openjdk.java.net/browse/JDK-8048264 Webrev+specdiff: http://cr.openjdk.java.net/~bchristi/8048264/webrev.0/ Thanks, -Brent
Re: RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException
Hi Brent, This looks fine You might need to fast track a CCC request even though this is minor Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 13, 2015, at 6:49 PM, Brent Christian brent.christ...@oracle.com wrote: Hello, Please review this small javadoc change. It was discovered that some codePoint-related methods in StringBuffer are missing documentation for throwing IndexOutOfBoundsException. The methods are: codePointAt(int) codePointBefore(int) codePointCount(int,int) offsetByCodePoints(int,int) The StringBuilder JavaDoc does have @throws tags for those methods. Bug: https://bugs.openjdk.java.net/browse/JDK-8048264 Webrev+specdiff: http://cr.openjdk.java.net/~bchristi/8048264/webrev.0/ Thanks, -Brent
Re: RFR 9: 8048264 : StringBuffer's codePoint methods throw unspecified IndexOutOfBoundsException
On 14/04/2015 8:49 AM, Brent Christian wrote: Hello, Please review this small javadoc change. It was discovered that some codePoint-related methods in StringBuffer are missing documentation for throwing IndexOutOfBoundsException. The methods are: codePointAt(int) codePointBefore(int) codePointCount(int,int) offsetByCodePoints(int,int) The StringBuilder JavaDoc does have @throws tags for those methods. Not that you need another review but Reviewed :) I really just wanted to add that I'm surprised that after all this time of having to deal with the complexity of javadoc inheritance rules, that we don't have anything to assist with detecting these omissions, as it is so easy to forget to redeclare unchecked exceptions. :( David Bug: https://bugs.openjdk.java.net/browse/JDK-8048264 Webrev+specdiff: http://cr.openjdk.java.net/~bchristi/8048264/webrev.0/ Thanks, -Brent
