Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

Hi Naoto, Thanks for fixing the original issue, and for filing the cleanup followup bug. s'marks On 3/3/18 9:30 AM, naoto.s...@oracle.com wrote: Hi Stuart, Filed an issue for the cleanup: https://bugs.openjdk.java.net/browse/JDK-8198989 Naoto On 3/2/18 5:50 PM, Stuart Marks wrote: Looks

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

Hi Stuart, Filed an issue for the cleanup: https://bugs.openjdk.java.net/browse/JDK-8198989 Naoto On 3/2/18 5:50 PM, Stuart Marks wrote: Looks good. I note that other codepoint-consuming methods, such as     Character.UnicodeBlock.of(cp)     Character.UnicodeScript.of(cp)    

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

Thanks - looks good. On Fri, Mar 2, 2018 at 3:37 PM, wrote: > Thanks for comments, Martin, Roger. Updated the fix as follows: > > http://cr.openjdk.java.net/~naoto/4993841/webrev.04/ > > Naoto > > > On 3/1/18 6:47 PM, naoto.s...@oracle.com wrote: > >> Hi, >> >> Please

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

Looks good. I note that other codepoint-consuming methods, such as Character.UnicodeBlock.of(cp) Character.UnicodeScript.of(cp) Character.toChars(cp, char[], int) Character.toChars(cp) Character.getName(cp) all throw IAE with no message. It would be nice to add messages to

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

. s'marks Rémi - Mail original - De: "naoto sato" <naoto.s...@oracle.com> À: "Stuart Marks" <stuart.ma...@oracle.com>, "Xueming Shen" <xueming.s...@gmail.com>, "core-libs-dev" <core-libs-dev@openjdk.java.net> Envoyé: Vendred

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

--- Mail original - > > De: "naoto sato" <naoto.s...@oracle.com> > > À: "Stuart Marks" <stuart.ma...@oracle.com>, "Xueming Shen" < > xueming.s...@gmail.com>, "core-libs-dev" > > <core-libs-dev@openjdk.java.net> >

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

+1 On 3/2/18, 3:37 PM, naoto.s...@oracle.com wrote: Thanks for comments, Martin, Roger. Updated the fix as follows: http://cr.openjdk.java.net/~naoto/4993841/webrev.04/ Naoto On 3/1/18 6:47 PM, naoto.s...@oracle.com wrote: Hi, Please review the fix to the following issue:

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

"core-libs-dev" <core-libs-dev@openjdk.java.net> Envoyé: Vendredi 2 Mars 2018 03:47:51 Objet: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-4993841 The

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

tuart Marks" <stuart.ma...@oracle.com>, "Xueming Shen" > <xueming.s...@gmail.com>, "core-libs-dev" > <core-libs-dev@openjdk.java.net> > Envoyé: Vendredi 2 Mars 2018 03:47:51 > Objet: [11] RFR: 4993841: (str) java.lang.Character should have a

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

Thanks for comments, Martin, Roger. Updated the fix as follows: http://cr.openjdk.java.net/~naoto/4993841/webrev.04/ Naoto On 3/1/18 6:47 PM, naoto.s...@oracle.com wrote: Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-4993841 The proposed

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

Hi Naoto, String.java: 3129: Please add a message to the throw IAE.  "Not a valid Unicode code point". Roger On 3/1/2018 9:47 PM, naoto.s...@oracle.com wrote: Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-4993841 The proposed changeset is

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

The multiple redundant bounds checks bother me, but I don't know how to fix them without abandoning a bit of modularization. if (cp >= 0) { if (COMPACT_STRINGS && cp < 0x100) return latin1encode() if (cp < MIN_SURROGATE || (cp > MAX_SURROGATE && cp < MIN_SUPPLEMENTARY_CODEPOINT) return

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

+ * @param codepoint a {@code codePoint}. does not match the formal parameter. javadoc -private should give an error on that.

[11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-4993841 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/4993841/webrev.03/ This stems from the recent discussion regarding String.repeat().[1] The corresponding CSR has already