Thanks for review, Paul.
Best regards,
Vladimir Ivanov
On 19.11.2019 21:25, Paul Sandoz wrote:
+1
On Nov 19, 2019, at 10:12 AM, Vladimir Ivanov
wrote:
Thanks, Paul.
CallSite:
public class CallSite {
- // The actual payload of this call site:
+ // The actual payload of this call
+1
> On Nov 19, 2019, at 10:12 AM, Vladimir Ivanov
> wrote:
>
> Thanks, Paul.
>
>> CallSite:
>> public class CallSite {
>> - // The actual payload of this call site:
>> + // The actual payload of this call site.
>> + // Can be modified using {@link
>>
Thanks, Paul.
CallSite:
public class CallSite {
- // The actual payload of this call site:
+ // The actual payload of this call site.
+ // Can be modified using {@link
MethodHandleNatives#setCallSiteTargetNormal} or {@link
MethodHandleNatives#setCallSiteTargetVolatile}.
Much better :-)
I accumulated some more questions while I was looking further.
CallSite:
public class CallSite {
-// The actual payload of this call site:
+// The actual payload of this call site.
+// Can be modified using {@link
MethodHandleNatives#setCallSiteTargetNormal} or
Subtle, so I could be misunderstanding something, did you intend to remove the
assignment of isFrozen in the ConstantCallSite constructor?
Oh, good catch. It is my fault: the update should be there. (The
barriers are added just to preserve final field semantics for isFrozen.)
Published
Ah the perils of partial construction :-)
Subtle, so I could be misunderstanding something, did you intend to remove the
assignment of isFrozen in the ConstantCallSite constructor?
ConstantCallSite:
protected ConstantCallSite(MethodType targetType, MethodHandle
createTargetHook) throws
