Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2020-02-11 Thread Sergey Bylokhov
I there are no objections I'll push the fix to JDK/client. On 12/11/19 7:29 pm, Igor Ignatyev wrote: Hi Sergey, overall looks good to me. a question about linux, is there an alternative to gnome-screenshot for DEs other than GNOME? -- Igor On Dec 11, 2019, at 1:00 AM, Sergey Bylokhov

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2020-01-06 Thread Sergey Bylokhov
On 1/6/20 8:41 pm, Philip Race wrote: How is this useful given that we disable jtreg failure handlers for the headful tests ? It is disabled only in mach5 for headful nightly and CI builds, but it is enabled for other builds, also it is enabled if the headful tests are executed standalone

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2020-01-06 Thread Philip Race
That didn't answer all my questions, at least not in a way that I can understand. How is this useful given that we disable jtreg failure handlers for the headful tests ? -phil. On 12/30/19, 11:33 AM, Sergey Bylokhov wrote: On 12/23/19 9:15 pm, Phil Race wrote: I am not sure what the right

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2019-12-30 Thread Sergey Bylokhov
On 12/23/19 9:15 pm, Phil Race wrote: I am not sure what the right mailing list(s) are for this change. It definitely isn't a core-libs change. I think build-dev may be better. Previous changes to these configs were discussed here, so I have send it here as well. I am also unclear when

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2019-12-23 Thread Phil Race
I am not sure what the right mailing list(s) are for this change. It definitely isn't a core-libs change. I think build-dev may be better. I am also unclear when this failure handler is invoked and how all this machinery works. It is only useful for headful tests and so I'd only want it

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2019-12-12 Thread Sergey Bylokhov
On 12/11/19 7:29 pm, Igor Ignatyev wrote: Hi Sergey, overall looks good to me. a question about linux, is there an alternative to gnome-screenshot for DEs other than GNOME? There are some alternatives like spectacle, mate-screenshot, xwd, imagemagick/import and some others, but non of them

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2019-12-11 Thread Igor Ignatyev
Hi Sergey, overall looks good to me. a question about linux, is there an alternative to gnome-screenshot for DEs other than GNOME? -- Igor > On Dec 11, 2019, at 1:00 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for JDK 14. > > Bug:

[14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2019-12-11 Thread Sergey Bylokhov
Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8233827 Fix: http://cr.openjdk.java.net/~serb/8233827/webrev.01 This change adds the "screen capture on the test failure" feature on macOS and Linux. - On Linux, it is implemented by the "gnome-screenshot"