Hi Naoto,
Looks good. Thanks for the updates.
Roger
On 1/16/20 4:08 PM, naoto.s...@oracle.com wrote:
Hi Roger,
Thanks. My comments are embedded below.
On 1/16/20 12:06 PM, Roger Riggs wrote:
Hi Naoto,
A couple of comments in the tests.
HijrahConfigTest:
72: Since onExit() starts a
Hi Roger,
Thanks. My comments are embedded below.
On 1/16/20 12:06 PM, Roger Riggs wrote:
Hi Naoto,
A couple of comments in the tests.
HijrahConfigTest:
72: Since onExit() starts a task in some executor and in some context,
its not clear that an exception thrown in that task will be
Hi Naoto,
A couple of comments in the tests.
HijrahConfigTest:
72: Since onExit() starts a task in some executor and in some context,
its not clear that an exception thrown in that task will be reported.
Use the normal p.waitFor() and check the exit code.
73: include the failed exit
Updated:
https://cr.openjdk.java.net/~naoto/8187987/webrev.02/
The change includes the new naming convention, reduction of properties
files reading to once, and utilization of logging.
Naoto
On 1/15/20 12:37 PM, Roger Riggs wrote:
Hi,
On 1/15/20 3:06 PM, naoto.s...@oracle.com wrote:
Hi
Hi,
On 1/15/20 3:06 PM, naoto.s...@oracle.com wrote:
Hi Roger,
Thank you for the review. Please find my comments below:
On 1/15/20 10:30 AM, Roger Riggs wrote:
Hi Naoto,
Is it correct to say that there is no impact on startup until there
is an explicit reference to HijrahChronology?
It
Hi Roger,
Thank you for the review. Please find my comments below:
On 1/15/20 10:30 AM, Roger Riggs wrote:
Hi Naoto,
Is it correct to say that there is no impact on startup until there is
an explicit reference to HijrahChronology?
It would seem that the registering HijrahChronology would
Hi Naoto,
Is it correct to say that there is no impact on startup until there is
an explicit reference to HijrahChronology?
It would seem that the registering HijrahChronology would trigger all
the work and that happens when Chronology is initialized. (see below)
HijrahChronology.java:
On 1/14/20 6:04 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Thank you for the review. Please find my comments below:
On 1/14/20 3:35 PM, Joe Wang wrote:
Hi Naoto,
Since it's dealing with non-standard properties files, is there a
need to verify the files? The constructor (HijrahChronology)
Hi Joe,
Thank you for the review. Please find my comments below:
On 1/14/20 3:35 PM, Joe Wang wrote:
Hi Naoto,
Since it's dealing with non-standard properties files, is there a need
to verify the files? The constructor (HijrahChronology) does check
whether the id or type is empty. If there
Hi Naoto,
Since it's dealing with non-standard properties files, is there a need
to verify the files? The constructor (HijrahChronology) does check
whether the id or type is empty. If there is no existing process to
validate, it's probably not worth it to spend time as it's rare and it's
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8187987
The proposed CSR and changeset are located at:
CSR: https://bugs.openjdk.java.net/browse/JDK-8236810
Webrev: https://cr.openjdk.java.net/~naoto/8187987/webrev.00/
The spec of
11 matches
Mail list logo
