Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-24 Thread David Holmes
On 25/06/2020 5:21 am, Mandy Chung wrote: Hi Roger, David, Thanks for the help in improving this.  As a record, this webrev shows the version as David suggests: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8247785/webrev.00/ Looks good to me :) Thanks, David Mandy On 6/24/20 9:33

Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-24 Thread Mandy Chung
Hi Roger, David, Thanks for the help in improving this.  As a record, this webrev shows the version as David suggests: http://cr.openjdk.java.net/~mchung/jdk15/webrevs/8247785/webrev.00/ Mandy On 6/24/20 9:33 AM, Roger Riggs wrote: Hi Mandy, I'm fine with this. Roger

Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-24 Thread Roger Riggs
Hi Mandy, I'm fine with this. Roger On 6/23/20 5:42 PM, Mandy Chung wrote: On 6/23/20 12:01 PM, Roger Riggs wrote: Hi Mandy, There may be a missing "to" in: + * Platform classes are visible the platform class loader ++ * Platform classes are visible *via* the platform class

Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-23 Thread David Holmes
On 24/06/2020 1:17 pm, Mandy Chung wrote: On 6/23/20 7:48 PM, David Holmes wrote: Hi Mandy, The trouble with small clarifications is that they tend to draw attention to larger issues :) On 24/06/2020 7:42 am, Mandy Chung wrote: On 6/23/20 12:01 PM, Roger Riggs wrote: Hi Mandy, There

Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-23 Thread Mandy Chung
On 6/23/20 7:48 PM, David Holmes wrote: Hi Mandy, The trouble with small clarifications is that they tend to draw attention to larger issues :) On 24/06/2020 7:42 am, Mandy Chung wrote: On 6/23/20 12:01 PM, Roger Riggs wrote: Hi Mandy, There may be a missing "to" in: + *

Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-23 Thread David Holmes
Hi Mandy, The trouble with small clarifications is that they tend to draw attention to larger issues :) On 24/06/2020 7:42 am, Mandy Chung wrote: On 6/23/20 12:01 PM, Roger Riggs wrote: Hi Mandy, There may be a missing "to" in: + * Platform classes are visible the platform class

Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-23 Thread Mandy Chung
On 6/23/20 12:01 PM, Roger Riggs wrote: Hi Mandy, There may be a missing "to" in: + * Platform classes are visible the platform class loader ++ * Platform classes are visible *via* the platform class loader I caught this accidental change too. The second change seems to be

Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-23 Thread Mandy Chung
On 6/23/20 12:15 PM, Brent Christian wrote: Hi, Mandy For: @@ -152,7 +152,7 @@   * The system class loader is typically used to define classes on the   * application class path, module path, and JDK-specific tools.   * The platform class loader is a parent or an ancestor of

Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-23 Thread Brent Christian
Hi, Mandy For: @@ -152,7 +152,7 @@ * The system class loader is typically used to define classes on the * application class path, module path, and JDK-specific tools. * The platform class loader is a parent or an ancestor of the system class - * loader that all platform

Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-23 Thread Roger Riggs
Hi Mandy, There may be a missing "to" in: + * Platform classes are visible the platform class loader ++ * Platform classes are visible *via* the platform class loader The second change seems to be self referential using "parent" to define itself. And pre-existing in the

Re: [15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-23 Thread Alan Bateman
On 23/06/2020 19:03, Mandy Chung wrote: Small clarification about the parent of the system class loader in the ClassLoader class spec: diff --git a/src/java.base/share/classes/java/lang/ClassLoader.java b/src/java.base/share/classes/java/lang/ClassLoader.java ---

[15] RFR JDK-8247785: Small clarification to the javadoc about builtin class loaders

2020-06-23 Thread Mandy Chung
Small clarification about the parent of the system class loader in the ClassLoader class spec: diff --git a/src/java.base/share/classes/java/lang/ClassLoader.java b/src/java.base/share/classes/java/lang/ClassLoader.java --- a/src/java.base/share/classes/java/lang/ClassLoader.java +++