Hello Stuart,
Thank you very much for your help in sponsoring this as well as the
detailed reviews and suggestions.
-Jaikiran
On Thursday, September 27, 2018, Stuart Marks
wrote:
> Hi, I just wanted to mention that I pushed the changeset for this bug:
>
>
Hi, I just wanted to mention that I pushed the changeset for this bug:
http://hg.openjdk.java.net/jdk/jdk/rev/2ee7e1b7ba66
Thanks for your contribution to OpenJDK!
s'marks
On 9/20/18 7:01 PM, Jaikiran Pai wrote:
Since you mentioned it I'll proceed with "Jaikiran Pai
" since that looks a bit more "official".
Sounds fine to me and yes it indeed is a bit more official one. Thank you.
OK, CSR request posted:
https://bugs.openjdk.java.net/browse/JDK-8210991
On 21/09/18 1:04 AM, Stuart Marks wrote:
>
>
> Since you mentioned it I'll proceed with "Jaikiran Pai
> " since that looks a bit more "official".
Sounds fine to me and yes it indeed is a bit more official one. Thank you.
-Jaikiran
On 9/19/18 7:46 PM, Jaikiran Pai wrote:
Thank you. More of a FYI and if it matters from a process point of view
- in a couple of my earlier contributions, the sponsors have used the
"Contributed-by" line to be "Jaikiran Pai " like
here http://hg.openjdk.java.net/jdk/jdk/rev/6c394ed56b07. I
Hello Stuart,
On 19/09/18 11:06 PM, Stuart Marks wrote:
>
>
>> While adding this, I realized that the current javadoc doesn't mention
>> anything about the behaviour of this method when a null array is passed
>> to it. The implementation currently throws a NullPointerException. So I
>> went
Stuart,
OK, I didn't know you already had that in mind.
-- Jon
On 09/19/2018 03:23 PM, Stuart Marks wrote:
Hi Jon,
Yes, definitely, given the scope of the current proposed changes, I
intend to file a CSR for this changeset on Jaikiran's behalf.
s'marks
On 9/19/18 10:42 AM, Jonathan
Hi Jon,
Yes, definitely, given the scope of the current proposed changes, I intend to
file a CSR for this changeset on Jaikiran's behalf.
s'marks
On 9/19/18 10:42 AM, Jonathan Gibbons wrote:
Jaikiran,
Referring back to the original email discussion, changes like this may require a
CSR to
Jaikiran,
Referring back to the original email discussion, changes like this may
require a
CSR to be filed.
From Stuart Marks:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-August/054894.html
Whether this requires a CSR depends on whether any normative text of the
specification
Hi Jaikiran,
Thanks for doing the updates and sending the patch.
Replies to your comments follow.
While adding this, I realized that the current javadoc doesn't mention
anything about the behaviour of this method when a null array is passed
to it. The implementation currently throws a
Hello Stuart,
Thank you very much for the detailed review. I have attached an updated
patch which incorporates the suggested changes. The complete javadoc
text is included inline here and a few comments are inline in the rest
of this mail:
/**
* Returns a fixed-size list backed by the
Hi Jaikiran,
Terribly sorry about this. I completely missed the review request you posted on
this a couple weeks ago now.
Comments below.
Returns a fixed-size list backed by the specified array.
OK. Same as the original. :-)
The passed array is held as a reference in the returned list.
Any other reviews? I'm not a committer, so I'll also need someone to
help sponsor this patch.
-Jaikiran
On 06/09/18 7:39 PM, Jaikiran Pai wrote:
> On 06/09/18 1:24 PM, Bernd Eckenfels wrote:
>> Yes you are right @apinote is aproperiate section (was confusing it with
>> implnote).
>>
>> Still
On 06/09/18 1:24 PM, Bernd Eckenfels wrote:
> Yes you are right @apinote is aproperiate section (was confusing it with
> implnote).
>
> Still think a ‚literal specified list‘ is no longer a good (as in canonical)
> usecase for that method.
>
> I used it in the past often to get a List for using
: [PATCH] JDK-7033681 - Improve the documentation of Arrays.asList
Hello Bernd,
Thank you for the review and sorry about the delayed response. Comments inline.
On 29/08/18 4:26 PM, Bernd Eckenfels wrote:
Hello,
Not an Reviewer But just wanted to give a short Feedback: I like the new
Version
Hello Bernd,
Thank you for the review and sorry about the delayed response. Comments
inline.
On 29/08/18 4:26 PM, Bernd Eckenfels wrote:
> Hello,
>
> Not an Reviewer But just wanted to give a short Feedback: I like the
> new Version it is really helpful.
>
> However I wonder if the usage
, 2018 9:07 AM
An: core-libs-dev@openjdk.java.net
Betreff: Re: [PATCH] JDK-7033681 - Improve the documentation of Arrays.asList
Anyone willing to help review the patch, please?
-Jaikiran
On 20/08/18 5:56 PM, Jaikiran Pai wrote:
> Hello everyone,
>
> I'm requesting a review of a docu
Anyone willing to help review the patch, please?
-Jaikiran
On 20/08/18 5:56 PM, Jaikiran Pai wrote:
> Hello everyone,
>
> I'm requesting a review of a documentation change which was discussed in
> a recent thread[1][2]. Here's an initial proposed draft, for a better
> documentation of
Hello everyone,
I'm requesting a review of a documentation change which was discussed in
a recent thread[1][2]. Here's an initial proposed draft, for a better
documentation of Arrays.asList method:
/**
* Returns a fixed-size list backed by the specified array. The passed
* array is
19 matches
Mail list logo
