Re: [jdk16] RFR: 8254350: CompletableFuture.get may swallow InterruptedException

2021-01-14 Thread Martin Buchholz
On Thu, 14 Jan 2021 13:59:50 GMT, Kezhu Wang wrote: >> 8254350: CompletableFuture.get may swallow InterruptedException > > @Martin-Buchholz @DougLea @AlanBateman Sorry for rough in. After change > `future.get()` to `future.get(1, TimeUnit.DAYS)`, > `SwallowedInterruptedException` failed.

Re: [jdk16] RFR: 8254350: CompletableFuture.get may swallow InterruptedException

2021-01-14 Thread Kezhu Wang
On Sun, 13 Dec 2020 03:31:44 GMT, Martin Buchholz wrote: > 8254350: CompletableFuture.get may swallow InterruptedException @Martin-Buchholz @DougLea @AlanBateman Sorry for rough in. After change `future.get()` to `future.get(1, TimeUnit.DAYS)`, `SwallowedInterruptedException` failed.

Re: [jdk16] RFR: 8254350: CompletableFuture.get may swallow InterruptedException

2020-12-13 Thread Doug Lea
On Sun, 13 Dec 2020 03:31:44 GMT, Martin Buchholz wrote: > 8254350: CompletableFuture.get may swallow InterruptedException Marked as reviewed by dl (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/17

Re: [jdk16] RFR: 8254350: CompletableFuture.get may swallow InterruptedException

2020-12-13 Thread Alan Bateman
On Sun, 13 Dec 2020 03:31:44 GMT, Martin Buchholz wrote: > 8254350: CompletableFuture.get may swallow InterruptedException Previously reviewed for openjdk/jdk, looks good. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk16/pull/17

[jdk16] RFR: 8254350: CompletableFuture.get may swallow InterruptedException

2020-12-12 Thread Martin Buchholz
8254350: CompletableFuture.get may swallow InterruptedException - Commit messages: - JDK-8254350 Changes: https://git.openjdk.java.net/jdk16/pull/17/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16=17=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254350 Stats: