Re: [jdk16] RFR: 8258007: Add instrumentation to NativeLibraryTest [v3]

2020-12-18 Thread Brent Christian
On Fri, 18 Dec 2020 23:31:35 GMT, Naoto Sato wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> format() -> println() > > test/lib/jdk/test/lib/util/ForceGC.java line 48: > >> 46: for (int i = 0; i <

Re: [jdk16] RFR: 8258007: Add instrumentation to NativeLibraryTest [v3]

2020-12-18 Thread Brent Christian
> This change adds some extra test output for NativeLibraryTest, primarily via > an update to the ForceGC utility class. > > It was observed that there was nothing preventing the Cleaner from cleaning > the short-lived Object that ForceGC registers before > await()/doit()/System.gc() is even

Re: [jdk16] RFR: 8258007: Add instrumentation to NativeLibraryTest [v2]

2020-12-18 Thread Mandy Chung
On Fri, 18 Dec 2020 23:37:11 GMT, Brent Christian wrote: >> This change adds some extra test output for NativeLibraryTest, primarily via >> an update to the ForceGC utility class. >> >> It was observed that there was nothing preventing the Cleaner from cleaning >> the short-lived Object that

Re: [jdk16] RFR: 8258007: Add instrumentation to NativeLibraryTest [v2]

2020-12-18 Thread Brent Christian
On Fri, 18 Dec 2020 22:43:16 GMT, Mandy Chung wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add sleep to ForceGC.await() > > test/lib/jdk/test/lib/util/ForceGC.java line 49: > >> 47:

Re: [jdk16] RFR: 8258007: Add instrumentation to NativeLibraryTest [v2]

2020-12-18 Thread Naoto Sato
On Fri, 18 Dec 2020 23:34:04 GMT, Brent Christian wrote: >> This change adds some extra test output for NativeLibraryTest, primarily via >> an update to the ForceGC utility class. >> >> It was observed that there was nothing preventing the Cleaner from cleaning >> the short-lived Object that

Re: [jdk16] RFR: 8258007: Add instrumentation to NativeLibraryTest [v2]

2020-12-18 Thread Brent Christian
> This change adds some extra test output for NativeLibraryTest, primarily via > an update to the ForceGC utility class. > > It was observed that there was nothing preventing the Cleaner from cleaning > the short-lived Object that ForceGC registers before > await()/doit()/System.gc() is even

Re: [jdk16] RFR: 8258007: Add instrumentation to NativeLibraryTest

2020-12-18 Thread Mandy Chung
On Fri, 18 Dec 2020 22:33:11 GMT, Brent Christian wrote: > This change adds some extra test output for NativeLibraryTest, primarily via > an update to the ForceGC utility class. > > It was observed that there was nothing preventing the Cleaner from cleaning > the short-lived Object that

[jdk16] RFR: 8258007: Add instrumentation to NativeLibraryTest

2020-12-18 Thread Brent Christian
This change adds some extra test output for NativeLibraryTest, primarily via an update to the ForceGC utility class. It was observed that there was nothing preventing the Cleaner from cleaning the short-lived Object that ForceGC registers before await()/doit()/System.gc() is even called. The