Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-23 Thread mark . reinhold
2019/10/23 12:37:56 -0700, bob.vande...@oracle.com: >> On Oct 23, 2019, at 3:07 PM, mark.reinh...@oracle.com wrote: >> ... >> >> Addendum: To keep things sane for JFR and the serviceability agent, >> I had to propagate this change through to those subsystems. >> >> Relative patch below; original

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-23 Thread Bob Vandette
> On Oct 23, 2019, at 3:07 PM, mark.reinh...@oracle.com wrote: > > 2019/10/22 15:36:28 -0700, mark.reinh...@oracle.com: >> 2019/10/22 12:43:42 -0700, bob.vande...@oracle.com: On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote: 2019/10/22 10:31:55 -0700,

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-23 Thread mark . reinhold
2019/10/22 15:36:28 -0700, mark.reinh...@oracle.com: > 2019/10/22 12:43:42 -0700, bob.vande...@oracle.com: >>> On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote: >>> 2019/10/22 10:31:55 -0700, bob.vande...@oracle.com: In arguments.cpp, could you use a new JVMFlag to declare options

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread Mandy Chung
On 10/22/19 3:37 PM, mark.reinh...@oracle.com wrote: 2019/10/22 14:12:18 -0700, mandy.ch...@oracle.com: On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote: RFE: https://bugs.openjdk.java.net/browse/JDK-8232080 CSR: https://bugs.openjdk.java.net/browse/JDK-8232753 Webrev:

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread Vladimir Kozlov
+1 Thanks Vladimir > On Oct 22, 2019, at 3:42 PM, Bob Vandette wrote: > > Hotspot changes look good to me. > > Bob. > > >> On Oct 22, 2019, at 6:36 PM, mark.reinh...@oracle.com wrote: >> >> 2019/10/22 12:43:42 -0700, bob.vande...@oracle.com: > On Oct 22, 2019, at 3:22 PM,

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread Bob Vandette
Hotspot changes look good to me. Bob. > On Oct 22, 2019, at 6:36 PM, mark.reinh...@oracle.com wrote: > > 2019/10/22 12:43:42 -0700, bob.vande...@oracle.com: >>> On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote: >>> 2019/10/22 10:31:55 -0700, bob.vande...@oracle.com: In

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread mark . reinhold
2019/10/22 14:12:18 -0700, mandy.ch...@oracle.com: > On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote: >> RFE: https://bugs.openjdk.java.net/browse/JDK-8232080 >> CSR: https://bugs.openjdk.java.net/browse/JDK-8232753 >> Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/ > > Looks good to me.

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread mark . reinhold
2019/10/22 12:43:42 -0700, bob.vande...@oracle.com: >> On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote: >> 2019/10/22 10:31:55 -0700, bob.vande...@oracle.com: >>> In arguments.cpp, could you use a new JVMFlag to declare options >>> that came from this resource as RESOURCE? >>> >>> -

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread Mandy Chung
On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote: RFE: https://bugs.openjdk.java.net/browse/JDK-8232080 CSR: https://bugs.openjdk.java.net/browse/JDK-8232753 Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/ Looks good to me.  One minor comment: AddResourcePlugin isn't really a

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread Bob Vandette
> On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote: > > 2019/10/22 10:31:55 -0700, bob.vande...@oracle.com: >> In arguments.cpp, could you use a new JVMFlag to declare options that came >> from this resource as RESOURCE? >> >> - jint result =

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread mark . reinhold
2019/10/22 7:15:10 -0700, alan.bate...@oracle.com: > On 22/10/2019 04:22, mark.reinh...@oracle.com wrote: >> RFE: https://bugs.openjdk.java.net/browse/JDK-8232080 >> CSR: https://bugs.openjdk.java.net/browse/JDK-8232753 >> Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/ > > I've read through

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread mark . reinhold
2019/10/22 10:31:55 -0700, bob.vande...@oracle.com: > In arguments.cpp, could you use a new JVMFlag to declare options that came > from this resource as RESOURCE? > > - jint result = parse_each_vm_init_arg(vm_options_args, _mod_javabase, > JVMFlag::INTERNAL); > + jint result =

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread Bob Vandette
In arguments.cpp, could you use a new JVMFlag to declare options that came from this resource as RESOURCE? - jint result = parse_each_vm_init_arg(vm_options_args, _mod_javabase, JVMFlag::INTERNAL); + jint result = parse_each_vm_init_arg(vm_options_args, _mod_javabase, JVMFlag::RESOURCE); This

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread Vladimir Kozlov
HotSpot changes seem fine to me. Thanks, Vladimir On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote: RFE: https://bugs.openjdk.java.net/browse/JDK-8232080 CSR: https://bugs.openjdk.java.net/browse/JDK-8232753 Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/ This change implements jlink

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread Alan Bateman
On 22/10/2019 04:22, mark.reinh...@oracle.com wrote: RFE: https://bugs.openjdk.java.net/browse/JDK-8232080 CSR: https://bugs.openjdk.java.net/browse/JDK-8232753 Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/ I've read through the code for the new jlink plugins and the changes to

Re: 14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-22 Thread Magnus Ihse Bursie
On 2019-10-22 05:22, mark.reinh...@oracle.com wrote: RFE: https://bugs.openjdk.java.net/browse/JDK-8232080 CSR: https://bugs.openjdk.java.net/browse/JDK-8232753 Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/ Build changes look good. /Magnus This change implements jlink plugins, and

14 RFR (M) 8232080: jlink plugins for vendor information and run-time options

2019-10-21 Thread mark . reinhold
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080 CSR: https://bugs.openjdk.java.net/browse/JDK-8232753 Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/ This change implements jlink plugins, and associated changes in the VM and libraries, to support the following new jlink options: -