David,
Thanks for taking a closer look. Really appreciate your detailed review.
On 6/23/11 1:33 PM, David Holmes wrote:
Sorry for the delay on this ...
I concur with Mandy that using arrive() the thread must always be
RUNNABLE or the expected next state. Hence the new check is ok.
With the
Chris Hegarty said the following on 06/23/11 20:22:
On 06/23/11 06:33 AM, David Holmes wrote:
Sorry for the delay on this ...
I concur with Mandy that using arrive() the thread must always be
RUNNABLE or the expected next state. Hence the new check is ok.
Thanks David,
With the new
Sorry for the delay on this ...
I concur with Mandy that using arrive() the thread must always be
RUNNABLE or the expected next state. Hence the new check is ok.
With the new synchronization (and perhaps even the old) it seems to me
that here:
private void setState(int newState) {
Hi Chris,
On 6/20/11 8:54 PM, Chris Hegarty wrote:
java/lang/Thread/ThreadStateTest.java can fail with when
checkThreadState finds an unexpected state.
Exception in thread main java.lang.RuntimeException: MyThread
expected to have TERMINATED but got RUNNABLE
at
Mandy Chung said the following on 06/21/11 20:08:
On 6/20/11 8:54 PM, Chris Hegarty wrote:
java/lang/Thread/ThreadStateTest.java can fail with when
checkThreadState finds an unexpected state.
Exception in thread main java.lang.RuntimeException: MyThread
expected to have TERMINATED but got
Thanks Alan, David, Mandy for you comments.
The retry loop in checkThreadState make sense. Is the 100ms sleep a
bit excessive? The thread will likely get to the expected state in a
fraction of that time.
True, reduced to 10ms.
I'm not sure the extra check in checkThreadState that the
On 06/21/11 12:12 PM, Chris Hegarty wrote:
Thanks Alan, David, Mandy for you comments.
The retry loop in checkThreadState make sense. Is the 100ms sleep a
bit excessive? The thread will likely get to the expected state in a
fraction of that time.
True, reduced to 10ms.
Oh, I also
On 6/21/11 7:12 PM, Chris Hegarty wrote:
[...]
I'm not sure the extra check in checkThreadState that the thread must
be RUNNABLE is valid. What if you are transitioning the thread from a
blocked to non-blocked state, you may still see it blocked on the
first call to getState.
L130-116: I
Chris Hegarty wrote:
java/lang/Thread/ThreadStateTest.java can fail with when
checkThreadState finds an unexpected state.
Exception in thread main java.lang.RuntimeException: MyThread
expected to have TERMINATED but got RUNNABLE
at
Hi Chris,
Chris Hegarty said the following on 06/20/11 22:54:
java/lang/Thread/ThreadStateTest.java can fail with when
checkThreadState finds an unexpected state.
Exception in thread main java.lang.RuntimeException: MyThread expected
to have TERMINATED but got RUNNABLE
at
10 matches
Mail list logo
