Re: Collections.addAll: remove outdated performance advice and add a note about atomicity

2018-02-05 Thread Tagir Valeev
Hello! Thank you for pointers to the previous discussions. Yes, I would suggest to consider a spec cleanup separately, because adding new Collection default method would certainly take much longer time to discuss. I agree that we can exclude the statement about atomicity if it causes doubts.

Re: Collections.addAll: remove outdated performance advice and add a note about atomicity

2018-02-01 Thread Stuart Marks
Links to existing material in OpenJDK: http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-December/050326.html https://bugs.openjdk.java.net/browse/JDK-8193031 I agree with the removal of the performance advice. We should also remove "identical"; my suggested replacement was

Re: Collections.addAll: remove outdated performance advice and add a note about atomicity

2018-01-30 Thread Martin Buchholz
I tried to tackle this here: http://openjdk.markmail.org/thread/eet2zd6ig3pfpv5g and it's still on my TODO list but not likely to get to top spot soon. On Tue, Jan 30, 2018 at 7:00 PM, Tagir Valeev wrote: > Hello! > > I suggest a patch for java.util.Collections#addAll

Collections.addAll: remove outdated performance advice and add a note about atomicity

2018-01-30 Thread Tagir Valeev
Hello! I suggest a patch for java.util.Collections#addAll JavaDoc: --- Collections.java2018-01-31 09:39:31.599107500 +0700 +++ Collections.java.patched2018-01-31 09:51:11.929059600 +0700 @@ -5406,4 +5406,8 @@ * The behavior of this convenience method is identical to that of - *