Core Libs Dev[9] Review Request for 8038795: tidy warnings cleanup for javax.management

2014-04-01 Thread alexander stepanov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8038795 Webrev corresponding: http://cr.openjdk.java.net/~yan/8038795/webrev.00/ Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected. Thanks. Regards, Alexander

Re: Core Libs Dev[9] Review Request for 8038795: tidy warnings cleanup for javax.management

2014-04-01 Thread Alan Bateman
I think you are looking for jmx-dev so forwarding to that list. On 01/04/2014 13:51, alexander stepanov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8038795 Webrev corresponding:

Re: Core Libs Dev[9] Review Request for 8038795: tidy warnings cleanup for javax.management

2014-04-01 Thread alexander stepanov
Thanks! On 01.04.2014 16:57, Alan Bateman wrote: I think you are looking for jmx-dev so forwarding to that list. On 01/04/2014 13:51, alexander stepanov wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8038795 Webrev

Re: Core Libs Dev[9] Review Request for 8038795: tidy warnings cleanup for javax.management

2014-04-01 Thread Alan Bateman
On 01/04/2014 14:31, alexander stepanov wrote: Thanks! I should have said that the changes look okay to me. I just assume the removal of the /p isn't really necessary. -Alan.

Re: jmx-dev Core Libs Dev[9] Review Request for 8038795: tidy warnings cleanup for javax.management

2014-04-01 Thread Daniel Fuchs
Hi Alexander, Looks good. I think I would remove the leading p in http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/remote/JMXPrincipal.java.frames.html as well. If you don't please check that the generated javadoc for JMXPrincipal.java still looks good.

Re: jmx-dev Core Libs Dev[9] Review Request for 8038795: tidy warnings cleanup for javax.management

2014-04-01 Thread Daniel Fuchs
On 4/1/14 4:41 PM, alexander stepanov wrote: Hello, Please see the updated webrev here: http://cr.openjdk.java.net/~yan/8038795/webrev.01/ Thanks Alexander, It looks good! -- daniel I just assume the removal of the /p isn't really necessary. Yes, probably. That was done just to make