Core Libs Dev[9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

2014-04-04 Thread alexander stepanov
Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8039172 Webrev corresponding: http://cr.openjdk.java.net/~yan/8039172/webrev.00/ Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected. Thanks. Regards, Alexander

Re: Core Libs Dev[9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

2014-04-04 Thread Lance @ Oracle
Looks ok but have one concern/question as to why you added the summary attribute to the table tag as it has been deprecated and believe it is not supported in HTML 5. I would probably not include it Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java

Re: Core Libs Dev[9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

2014-04-04 Thread alexander stepanov
Hello Lance, Thank you for the note; the summaries were removed, please see the updated webrev: http://cr.openjdk.java.net/~yan/8039172/webrev.01/ Regards, Alexander On 04.04.2014 15:16, Lance @ Oracle wrote: Looks ok but have one concern/question as to why you added the summary attribute

Re: Core Libs Dev[9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

2014-04-04 Thread Lance @ Oracle
Looks fine Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 4, 2014, at 7:53 AM, alexander stepanov alexander.v.stepa...@oracle.com wrote: Hello Lance,

Re: Core Libs Dev[9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

2014-04-04 Thread Alan Bateman
On 04/04/2014 12:53, alexander stepanov wrote: Hello Lance, Thank you for the note; the summaries were removed, please see the updated webrev: http://cr.openjdk.java.net/~yan/8039172/webrev.01/ I looked through the updated webrev and it looks okay to me. One suggestion for

Re: Core Libs Dev[9] Review request for 8039172: Tidy warnings cleanup for java.net, java.math, java.time, java.rmi

2014-04-04 Thread alexander stepanov
Thanks; the line in net-properties.html was splitted. Regards, Alexander On 04.04.2014 19:25, Alan Bateman wrote: On 04/04/2014 12:53, alexander stepanov wrote: Hello Lance, Thank you for the note; the summaries were removed, please see the updated webrev: