On 07/03/2013 02:57, Martin Buchholz wrote:
Pushed to jdk8/tl/jdk.
I recommend this be backported to jdk7u.
I agree that it would be good to backport. It doesn't happen
automatically so you'll need to mail jdk7u-dev asking for approved to
push it to jdk7u/jdk7u-dev.
-Alan
Changeset: 14e49a70729a
Author:martin
Date: 2013-03-06 17:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/14e49a70729a
8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so
Summary: Define FILES_m to force use of linker script
Reviewed-by: sherman
Pushed to jdk8/tl/jdk.
I recommend this be backported to jdk7u.
On 28/02/2013 16:11, Martin Buchholz wrote:
On Thu, Feb 28, 2013 at 6:03 AM, Alan Bateman alan.bate...@oracle.com
mailto:alan.bate...@oracle.com wrote:
The update to make/java/zip/Makefile looks good to me, we should
have done it a long time ago. I assume you are pushing ahead on
On Mar 1, 2013, at 6:44 AM, Alan Bateman wrote:
It's hard to find something more standard than stddef.h.
It's hard to find something as non-standard as Windows. My point was we just
need to double check that this builds okay on Windows, which is does.
The only issue I have seen with
On Thu, Feb 28, 2013 at 6:03 AM, Alan Bateman alan.bate...@oracle.comwrote:
The update to make/java/zip/Makefile looks good to me, we should have
done it a long time ago. I assume you are pushing ahead on this because you
want to push it to jdk7u-dev (as it's not interesting to jdk8 now
I have another iteration of this change
http://cr.openjdk.java.net/~martin/webrevs/openjdk8/hide-zlib/
that adds exciting new exception detail message for the InternalError I was
scratching my head about earlier.
-msg = strm-msg;
+msg = ((strm-msg != NULL) ? strm-msg :
+
On Feb 23, 2013, at 12:12 PM, Alan Bateman wrote:
On 23/02/2013 18:06, Martin Buchholz wrote:
I am actually encountering this in openjdk7 with the old build system.
I can repro the problem in openjdk8 with the old build system, but not the
new one.
I don't know if you consider this a bug
Kelly,
Thanks. I think we agree.
I think we have consensus that my change is an improvement and should be
committed.
Can I haz approval?
I'm not brave enough to try to change the default for all mapfiles,
although I would support Kelly or anyone else who tries.
Martin
On Mon, Feb 25, 2013 at
On 22/02/2013 22:03, Martin Buchholz wrote:
Hi Alan, Xueming, build-ers,
I'd like you to do a code review.
I've finally figured out why fastdebug jdk occasionally gives
InternalError in the zip code.
Exception in thread main java.lang.InternalError
at java.util.zip.Inflater.init(Native
I am actually encountering this in openjdk7 with the old build system.
I can repro the problem in openjdk8 with the old build system, but not the
new one.
I don't know if you consider this a bug with the new build system - it's
supposed to generate the same bits, after all???!!
I'm not sure why
On 23/02/2013 18:06, Martin Buchholz wrote:
I am actually encountering this in openjdk7 with the old build system.
I can repro the problem in openjdk8 with the old build system, but not
the new one.
I don't know if you consider this a bug with the new build system -
it's supposed to generate
Hi Alan, Xueming, build-ers,
I'd like you to do a code review.
I've finally figured out why fastdebug jdk occasionally gives InternalError
in the zip code.
Exception in thread main java.lang.InternalError
at java.util.zip.Inflater.init(Native Method)
at
Here is the bugid you will need.
8008759: Do not let internal JDK zlib symbols leak out of fastdebug libzip.so
On 02/22/2013 02:03 PM, Martin Buchholz wrote:
Hi Alan, Xueming, build-ers,
I'd like you to do a code review.
I've finally figured out why fastdebug jdk occasionally gives
On Fri, Feb 22, 2013 at 2:15 PM, Xueming Shen xueming.s...@oracle.comwrote:
**
Here is the bugid you will need.
8008759: Do not let internal JDK zlib symbols leak out of fastdebug
libzip.so
Thanks! webrev updated.
15 matches
Mail list logo
