Re: FW: RFR: JDK8U Backport of JDK-8212941: Support new Japanese era in java.time.chrono.JapaneseEra

2019-01-28 Thread Seán Coffey
Thanks for the reviews. Here's the final webrev which I hope to sponsor for Deepak once I have the necessary approvals. http://cr.openjdk.java.net/~coffeys/webrev.8212941.jdk8u/webrev/ Regards, Sean. On 28/01/19 16:06, Naoto Sato wrote: +1 Naoto On 1/28/19 3:18 AM, Chris Hegarty wrote:

Re: FW: RFR: JDK8U Backport of JDK-8212941: Support new Japanese era in java.time.chrono.JapaneseEra

2019-01-28 Thread Naoto Sato
+1 Naoto On 1/28/19 3:18 AM, Chris Hegarty wrote: On 27/01/2019 11:54, Deepak Kejriwal wrote: ... Hi All, JBS report: https://bugs.openjdk.java.net/browse/JDK-8212941 Webrev: http://cr.openjdk.java.net/~rpatil/8212941/jdk8u/webrev.00/ This looks good Deepak. Reviewed. One minor

Re: FW: RFR: JDK8U Backport of JDK-8212941: Support new Japanese era in java.time.chrono.JapaneseEra

2019-01-28 Thread Chris Hegarty
On 27/01/2019 11:54, Deepak Kejriwal wrote: ... Hi All, JBS report: https://bugs.openjdk.java.net/browse/JDK-8212941 Webrev: http://cr.openjdk.java.net/~rpatil/8212941/jdk8u/webrev.00/ This looks good Deepak. Reviewed. One minor comment. "The of(int) and valueOf(String) methods ...",

FW: RFR: JDK8U Backport of JDK-8212941: Support new Japanese era in java.time.chrono.JapaneseEra

2019-01-27 Thread Deepak Kejriwal
+ jdk8u-dev. From: Deepak Kejriwal Sent: Saturday, January 26, 2019 4:27 PM To: core-libs-dev ; jdk-updates-...@openjdk.java.net Subject: RFR: JDK8U Backport of JDK-8212941: Support new Japanese era in java.time.chrono.JapaneseEra Hi All, JBS report: