Re: FYC: 7197183 : Provide CharSequence.subSequenceView which allows for sub-sequence views of character sequences.

2014-07-18 Thread Peter Levart
Hi Mike, Just a warning that CharSubSequenceView is a public class, which is not what you wanted it to be, I think, since its constructors are pkg private. IntSupplier trick is nice, but it makes the wrapper object heavier. If the purpose was to support tracking source sequence length with some

Re: FYC: 7197183 : Provide CharSequence.subSequenceView which allows for sub-sequence views of character sequences.

2014-07-17 Thread Michael Kay
In my own product (Saxon) I have a class CharSlice which is pretty much identical to your CharSubSequenceView. So yes, I think it is useful. Michael Kay Saxonica m...@saxonica.com +44 (0118) 946 5893 On 17 Jul 2014, at 01:09, Mike Duigou mike.dui...@oracle.com wrote: Hello all; In Java

Re: FYC: 7197183 : Provide CharSequence.subSequenceView which allows for sub-sequence views of character sequences.

2014-07-17 Thread Claes Redestad
Hi Mike, while nicely abstracting the problem, promoting developers to re-introduce some of the leakiness that the 7u6 String changes helped remove is something I think we should be wary of. If anything I think such an object should not be Serializable; maybe even have hashCode() throw

FYC: 7197183 : Provide CharSequence.subSequenceView which allows for sub-sequence views of character sequences.

2014-07-16 Thread Mike Duigou
Hello all; In Java 7u6 there was a significant change in the implementation of java.lang.String (JDK-6924259). This was done to reduce the size of String instances and it has been generally regarded as a positive change. As with almost any significant change to a class as core to Java as

Re: FYC: 7197183 : Provide CharSequence.subSequenceView which allows for sub-sequence views of character sequences.

2014-07-16 Thread Louis Wasserman
If I recall correctly, CharBuffer.wrap(charSequence).subSequence(from, to) has equivalent semantics without requiring a new implementation, even if the implementation is fairly simple. On Wed, Jul 16, 2014 at 5:09 PM, Mike Duigou mike.dui...@oracle.com wrote: Hello all; In Java 7u6 there was