On Wed, 25 Nov 2020 12:41:40 GMT, Chris Hegarty <che...@openjdk.org> wrote:
> The ByteBuffers micro benchmark seems to be a little dated. > > It should be a useful resource to leverage when analysing the performance > impact of any potential implementation changes in the byte buffer classes. > More specifically, the impact of such changes on the performance of sharp > memory access operations. > > This issue proposes to update the benchmark in the following ways to meet the > aforementioned use-case: > > 1. Remove allocation from the individual benchmarks - it just creates noise. > 2. Consolidate per-thread shared heap and direct buffers. > 3. All scenarios now use absolute memory access operations - so no state of > the shared buffers is considered. > 4. Provide more reasonable default fork, warmup, etc, out-of-the-box. > 5. There seems to have been an existing bug in the test where the size > parameter was not always considered - this is now fixed. This pull request has now been integrated. Changeset: ac276bb3 Author: Chris Hegarty <che...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/ac276bb3 Stats: 2771 lines in 11 files changed: 2612 ins; 9 del; 150 mod 8257074: Update the ByteBuffers micro benchmark Reviewed-by: redestad, dfuchs, jvernee, bpb ------------- PR: https://git.openjdk.java.net/jdk/pull/1430
