RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

2019-01-29 Thread Langer, Christoph
Done: http://hg.openjdk.java.net/jdk/jdk/rev/4cfa5f51eafa From: Steve Groeger Sent: Montag, 28. Januar 2019 17:25 To: Langer, Christoph Cc: core-libs-dev@openjdk.java.net; Roger Riggs Subject: RE: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

2019-01-28 Thread Steve Groeger
java.net" Date: 28/01/2019 15:49 Subject: RE: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi Steve, Roger, I made some additional cleanups in the test (Declare constants final, formatting, nice up error output...) This is what

Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

2019-01-28 Thread Roger Riggs
essage- From: core-libs-dev On Behalf Of Roger Riggs Sent: Freitag, 25. Januar 2019 17:52 To: Steve Groeger Cc: core-libs-dev@openjdk.java.net Subject: Re: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail +1, Thanks, Roger On 01/25/2019 11:21 AM,

RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

2019-01-28 Thread Langer, Christoph
17:52 > To: Steve Groeger > Cc: core-libs-dev@openjdk.java.net > Subject: Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java > passes even when test should fail > > +1, > > Thanks, Roger > > > On 01/25/2019 11:21 AM, Steve Groeger wrote: > &g

Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

2019-01-25 Thread Roger Riggs
system and see if we see > any issues. > > Is it ok for you if we do the fix just in the jdk branch (JDK13) or are > you particularly interested in getting this fixed for jdk12 and/or jdk11u? > > Best regards > Christoph > >> -Original Message----- >> From:

Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

2019-01-25 Thread Steve Groeger
: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Roger Riggs To: core-libs-dev@openjdk.java.net Date: 25/01/2019 15:30 Subject:Re: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Sent by:"core-libs-dev&qu

Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

2019-01-25 Thread Roger Riggs
25/01/2019 14:30 Subject: RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi Steve, in general this change looks reasonable to me. I think in case there is an error, it would be useful to get a printout of the expected/vs actual st

RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

2019-01-25 Thread Steve Groeger
Steve Groeger Cc: core-libs Date: 25/01/2019 14:30 Subject: RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi Steve, in general this change looks reasonable to me. I think in case there is an error, it would be use

RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

2019-01-25 Thread Langer, Christoph
bs-dev On Behalf > Of Steve Groeger > Sent: Freitag, 25. Januar 2019 12:40 > To: core-libs > Subject: RFR: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java > passes even when test should fail > > Hi all, > > I have found an issue with the jdk/java/util/prefs/E

RFR: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail

2019-01-25 Thread Steve Groeger
Hi all, I have found an issue with the jdk/java/util/prefs/ExportSubtree.java test. Using jtreg to run this test the test passes no matter what happens within the test. Have raised an issue for this: https://bugs.openjdk.java.net/browse/JDK-821 I think the issue is 2 fold: 1) the test