Re: JDK 11 RFR of JDK-8201766: Mark TimSortStackSize2.java as intermittently failing

2018-04-17 Thread David Holmes

Looks fine to me Joe!

Thanks,
David

On 18/04/2018 1:59 PM, joe darcy wrote:

Hello,

Please review the patch below to address

     JDK-8201766: Mark TimSortStackSize2.java as intermittently failing

which marks the test as failing intermittently and demotes it to tier 2 
from tier 1.


Thanks,

-Joe

diff -r 4c77b1453427 test/jdk/TEST.groups
--- a/test/jdk/TEST.groups    Tue Apr 17 16:13:30 2018 -0700
+++ b/test/jdk/TEST.groups    Tue Apr 17 20:57:01 2018 -0700
@@ -1,4 +1,4 @@
-#  Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights 
reserved.
+#  Copyright (c) 2013, 2018, Oracle and/or its affiliates. All rights 
reserved.

  #  DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  #
  #  This code is free software; you can redistribute it and/or modify it
@@ -34,12 +34,14 @@
  java/nio/Buffer \
  com/sun/crypto/provider/Cipher \
  :jdk_math \
-    tools/pack200
+    tools/pack200 \
+    -java/util/Arrays/TimSortStackSize2.java

  tier2 = \
  :tier2_part1 \
  :tier2_part2 \
-    :tier2_part3
+    :tier2_part3 \
+    java/util/Arrays/TimSortStackSize2.java

  # com/sun/crypto/provider/Cipher is in tier1 because of JDK-8132855
  tier2_part1 = \
diff -r 4c77b1453427 test/jdk/java/util/Arrays/TimSortStackSize2.java
--- a/test/jdk/java/util/Arrays/TimSortStackSize2.java    Tue Apr 17 
16:13:30 2018 -0700
+++ b/test/jdk/java/util/Arrays/TimSortStackSize2.java    Tue Apr 17 
20:57:01 2018 -0700

@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights 
reserved.

   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -34,6 +34,7 @@
   * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions
   * -XX:+WhiteBoxAPI TimSortStackSize2
   * @summary Test TimSort stack size on big arrays
+ * @key intermittent
   */
  import java.util.ArrayList;
  import java.util.Arrays;



JDK 11 RFR of JDK-8201766: Mark TimSortStackSize2.java as intermittently failing

2018-04-17 Thread joe darcy

Hello,

Please review the patch below to address

    JDK-8201766: Mark TimSortStackSize2.java as intermittently failing

which marks the test as failing intermittently and demotes it to tier 2 
from tier 1.


Thanks,

-Joe

diff -r 4c77b1453427 test/jdk/TEST.groups
--- a/test/jdk/TEST.groups    Tue Apr 17 16:13:30 2018 -0700
+++ b/test/jdk/TEST.groups    Tue Apr 17 20:57:01 2018 -0700
@@ -1,4 +1,4 @@
-#  Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights 
reserved.
+#  Copyright (c) 2013, 2018, Oracle and/or its affiliates. All rights 
reserved.

 #  DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 #
 #  This code is free software; you can redistribute it and/or modify it
@@ -34,12 +34,14 @@
 java/nio/Buffer \
 com/sun/crypto/provider/Cipher \
 :jdk_math \
-    tools/pack200
+    tools/pack200 \
+    -java/util/Arrays/TimSortStackSize2.java

 tier2 = \
 :tier2_part1 \
 :tier2_part2 \
-    :tier2_part3
+    :tier2_part3 \
+    java/util/Arrays/TimSortStackSize2.java

 # com/sun/crypto/provider/Cipher is in tier1 because of JDK-8132855
 tier2_part1 = \
diff -r 4c77b1453427 test/jdk/java/util/Arrays/TimSortStackSize2.java
--- a/test/jdk/java/util/Arrays/TimSortStackSize2.java    Tue Apr 17 
16:13:30 2018 -0700
+++ b/test/jdk/java/util/Arrays/TimSortStackSize2.java    Tue Apr 17 
20:57:01 2018 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -34,6 +34,7 @@
  * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions
  * -XX:+WhiteBoxAPI TimSortStackSize2
  * @summary Test TimSort stack size on big arrays
+ * @key intermittent
  */
 import java.util.ArrayList;
 import java.util.Arrays;