Re: JDK 12 RFR of 5075463 : (enum) Serialized Form javadoc for java.lang.Enum is misleading

2018-08-15 Thread joe darcy
Hi Roger, Filed JDK-8209542: "Serialization discussion of enum types should mention java.lang.Enum." Thanks for the review, -Joe On 8/15/2018 6:20 AM, Roger Riggs wrote: Hi Joe, This change looks fine as the spec for serializing Enum's is in OIS and OOS. However, the spec for

Re: JDK 12 RFR of 5075463 : (enum) Serialized Form javadoc for java.lang.Enum is misleading

2018-08-15 Thread Roger Riggs
Hi Joe, This change looks fine as the spec for serializing Enum's is in OIS and OOS. However, the spec for serializing Enum's in ObjectInputStream and ObjectOutputStream is incomplete. It does not mention that the class of the Enum is written to the stream before the enum name. Please file

Re: JDK 12 RFR of 5075463 : (enum) Serialized Form javadoc for java.lang.Enum is misleading

2018-08-15 Thread Lance Andersen
Hi Joe, Added myself as a reviewer to the CSR and the change looks fine On Aug 14, 2018, at 11:59 PM, joe darcy wrote: > https://bugs.openjdk.java.net/browse/JDK-8209524 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive

JDK 12 RFR of 5075463 : (enum) Serialized Form javadoc for java.lang.Enum is misleading

2018-08-14 Thread joe darcy
Hello, Cleaning out an old bug, please review the CSR and fix for:     JDK-5075463 : (enum) Serialized Form javadoc for java.lang.Enum is misleading     http://cr.openjdk.java.net/~darcy/5075463.0/     CSR: https://bugs.openjdk.java.net/browse/JDK-8209524 The abstract class java.lang.Enum