JDK 8 RFR of javax.script doclint fixes

2013-12-03 Thread Joe Darcy
Hello, Please review the patch before which addresses a handful of doclint issues in javax.script. Thanks, -Joe diff -r c11553506228 src/share/classes/javax/script/ScriptEngineFactory.java --- a/src/share/classes/javax/script/ScriptEngineFactory.javaTue Dec 03 08:53:23 2013 +0100 +++

Re: JDK 8 RFR of javax.script doclint fixes

2013-12-03 Thread Mike Duigou
Approved. On Dec 3 2013, at 09:49 , Joe Darcy joe.da...@oracle.com wrote: Hello, Please review the patch before which addresses a handful of doclint issues in javax.script. Thanks, -Joe diff -r c11553506228 src/share/classes/javax/script/ScriptEngineFactory.java ---

Re: JDK 8 RFR of javax.script doclint fixes

2013-12-03 Thread Chris Hegarty
Looks fine to me Joe. -Chris. On 3 Dec 2013, at 17:49, Joe Darcy wrote: Hello, Please review the patch before which addresses a handful of doclint issues in javax.script. Thanks, -Joe diff -r c11553506228 src/share/classes/javax/script/ScriptEngineFactory.java ---

Re: JDK 8 RFR of javax.script doclint fixes

2013-12-03 Thread roger riggs
Hi Joe, looks fine, Not a reviewer, Roger On 12/3/2013 12:49 PM, Joe Darcy wrote: Hello, Please review the patch before which addresses a handful of doclint issues in javax.script. Thanks, -Joe diff -r c11553506228 src/share/classes/javax/script/ScriptEngineFactory.java ---

Re: JDK 8 RFR of javax.script doclint fixes

2013-12-03 Thread roger riggs
Hi, Not specific to your change, but the previous sentences end in ; in some cases and : in others. I thing : colon is more natural. Roger On 12/3/2013 12:55 PM, roger riggs wrote: Hi Joe, looks fine, Not a reviewer, Roger On 12/3/2013 12:49 PM, Joe Darcy wrote: Hello, Please review