Re: JDK 9 RFR - 8031142 [was: Re: Using @implSpec in AbstractMap, AbstractCollection, AbstractList, etc]

2014-01-07 Thread Chris Hegarty
On 6 Jan 2014, at 21:19, Martin Buchholz wrote: > Your change looks good, except there's one more trailing to remove. Thanks for the review. I found the trailing and removed it. -Chris.

Re: JDK 9 RFR - 8031142 [was: Re: Using @implSpec in AbstractMap, AbstractCollection, AbstractList, etc]

2014-01-06 Thread Chris Hegarty
On 6 Jan 2014, at 18:11, Chris Hegarty wrote: > On 6 Jan 2014, at 17:05, Martin Buchholz wrote: > …….. >> >> In a sane language, the AbstractFoo classes would be traits - they should >> never contribute to the *specification* of a concrete class, only to its >> implementation. Therefore, i

JDK 9 RFR - 8031142 [was: Re: Using @implSpec in AbstractMap, AbstractCollection, AbstractList, etc]

2014-01-06 Thread Chris Hegarty
Part 2... JDK 9 RFR - 8031142: AbstractCollection and AbstractList should specify their default implementation using @implSpec http://cr.openjdk.java.net/~chegar/8031142/webrev/ http://cr.openjdk.java.net/~chegar/8031142/specdiff/ -Chris. On 06/01/14 15:37, Mike Duigou wrote: Coming in late

Re: JDK 9 RFR - 8031142 [was: Re: Using @implSpec in AbstractMap, AbstractCollection, AbstractList, etc]

2014-01-06 Thread Mike Duigou
If you navigate through http://cr.openjdk.java.net/~chegar/8031142/specdiff/java/util/package-summary.html it shows just the relevant diffs. It appears that the specdiff was generated without an explicit --includes option which results in all the extra chaff. Mike On Jan 6 2014, at 09:05 , Mar

Re: JDK 9 RFR - 8031142 [was: Re: Using @implSpec in AbstractMap, AbstractCollection, AbstractList, etc]

2014-01-06 Thread Chris Hegarty
On 6 Jan 2014, at 17:05, Martin Buchholz wrote: > On Mon, Jan 6, 2014 at 8:47 AM, Chris Hegarty > wrote: > Part 2... > > JDK 9 RFR - 8031142: AbstractCollection and AbstractList should specify their > default implementation using @implSpec > > http://cr.openjdk.java.net/~chegar/8031142/webre

Re: JDK 9 RFR - 8031142 [was: Re: Using @implSpec in AbstractMap, AbstractCollection, AbstractList, etc]

2014-01-06 Thread Chris Hegarty
On 6 Jan 2014, at 17:25, Martin Buchholz wrote: > > On Mon, Jan 6, 2014 at 9:19 AM, Mike Duigou wrote: > If you navigate through > http://cr.openjdk.java.net/~chegar/8031142/specdiff/java/util/package-summary.html > it shows just the relevant diffs. It appears that the specdiff was generated