Re: JDK 9 RFR of JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache}

2014-01-07 Thread Lance Andersen - Oracle
looks good Joe On Jan 7, 2014, at 6:58 PM, Joe Darcy wrote: > Hello, > > Please review the fix below to address > >JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache} > > by a quick-and-dirty generification and deprecation of some very old classes > >http://cr.openjdk.ja

Re: JDK 9 RFR of JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache}

2014-01-07 Thread Joe Darcy
Hi Mike, On 01/07/2014 05:23 PM, Mike Duigou wrote: Can you add the javadoc @deprecated deprecation notice as well? Sure; for Cache I'll point to LinkedHashMap and I'll look into finding a alternative to SoftCache. Thanks for the review, -Joe Otherwise looks good. Mike On Jan 7 2014,

Re: JDK 9 RFR of JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache}

2014-01-07 Thread Mike Duigou
Can you add the javadoc @deprecated deprecation notice as well? Otherwise looks good. Mike On Jan 7 2014, at 15:58 , Joe Darcy wrote: > Hello, > > Please review the fix below to address > >JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache} > > by a quick-and-dirty generi

JDK 9 RFR of JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache}

2014-01-07 Thread Joe Darcy
Hello, Please review the fix below to address JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache} by a quick-and-dirty generification and deprecation of some very old classes http://cr.openjdk.java.net/~darcy/8031369.0/ Corresponding patch below. In the fullness of tim