Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-14 Thread Alan Bateman
Mandy Chung wrote: Hi Martin, Thanks for catching the regression. I created a Sun bug # 6829503 for bug 2. With the fix for 6829503, ApplicationShutdownHook and DeleteOnExitHook are both lazily initialized. Since it is possible that a file could be added to the list for DeletedOnExit

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-14 Thread Franz Wong
Dear all, Seem you guy are fixing the bug about shutdown of logger, can you please also take a look at the bug I filed in Sun database (#6774110) Thanks.

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-14 Thread Mandy Chung
Alan Bateman wrote: That bug is that deleteOnExit is throwing IllegalStateException during shutdown when it shouldn't. That bug has been there for a while but has been masked by 6526376 (fixed early in jdk7). Before the fix for 6829503 (after 6526376 was fixed), DeleteOnExitHook#add never

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-14 Thread Martin Buchholz
It does look like we're taking over maintainership of java.util.logging, and there is a current flurry of activity, but probably no one here is thinking along those lines. Martin On Tue, Apr 14, 2009 at 06:38, Franz Wong franzp...@gmail.com wrote: Dear all, Seem you guy are fixing the bug

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-13 Thread Martin Buchholz
I've put the patch up on http://cr.openjdk.java.net/~martin/LoggingDeadlock2 (my first use (or abuse? I didn't use webrev) of cr.openjdk.java.net) I am not a shutdown hook expert - everything I know about shutdown hooks I learned while tracking down LoggingDeadlock2 failures. So I agree it

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-13 Thread Martin Buchholz
On Mon, Apr 13, 2009 at 10:56, Mandy Chung mandy.ch...@sun.com wrote: With the fix for 6829503, ApplicationShutdownHook and DeleteOnExitHook are both lazily initialized.  Since it is possible that a file could be added to the list for DeletedOnExit during shutdown, perhaps we also need to

Re: PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-13 Thread David Holmes - Sun Microsystems
I concur with the caution here. When looking at the lazy initialization change, it never occurred to me that first-use could actually occur after shutdown had commenced. David Martin Buchholz said the following on 04/14/09 06:57: On Mon, Apr 13, 2009 at 10:56, Mandy Chung mandy.ch...@sun.com

PATCH: ShutdownHooks and LoggingDeadlock2

2009-04-12 Thread Martin Buchholz
Hi ShutdownHooks/Logging maintainers (especially Mandy), This is a bug report for *two* bugs, with fix. Bug 1: Synopsis: test/java/util/logging/LoggingDeadlock2.java is flaky Description: The reg test java/util/logging/LoggingDeadlock2.java has been failing intermittently for quite a while, at