Re: Question about the bug https://bugs.openjdk.java.net/browse/JDK-8031179

2014-01-29 Thread Stuart Marks
Hi Eric, Thanks for the updates. I've pushed this changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/97dc93591ae7 A few comments and minor corrections. 1. There was no changeset in the webrev; it was still just a plain patch. Depending on how you ran webrev, you might have stumbled over a

Re: Question about the bug https://bugs.openjdk.java.net/browse/JDK-8031179

2014-01-25 Thread Eric Wang
Hi Stuart, I have made changes based on your comments. Can you please review again? Thanks a lot! http://cr.openjdk.java.net/~ewang/JDK-8031179/webrev.01/ Eric On 2014/1/25 8:53, Stuart Marks wrote: Hi Eric, OK, overall this looks

Re: Question about the bug https://bugs.openjdk.java.net/browse/JDK-8031179

2014-01-24 Thread Stuart Marks
Hi Eric, OK, overall this looks good. There are a few adjustments I'd like you to make before I push it for you. Part of this is to get you to do a more complete job of preparing changesets, and part of it is to make my job as a sponsor easier. :-) Oh, and there a couple style issues as well.

Re: Question about the bug https://bugs.openjdk.java.net/browse/JDK-8031179

2014-01-24 Thread Eric Wang
Hi Stuart, Please review the webrev http://cr.openjdk.java.net/~ewang/JDK-8031179/webrev.00/, if you are OK with the changes, could you please be my sponsor? Thanks, Eric On 2014/1/24 15:14, Eric Wang wrote: Hi Stuart, Thanks for the suggestion! sorry for reply this mail late as i was busy

Re: Question about the bug https://bugs.openjdk.java.net/browse/JDK-8031179

2014-01-23 Thread Eric Wang
Hi Stuart, Thanks for the suggestion! sorry for reply this mail late as i was busy on other tasks The webrev has been in the internal review process. Based on the suggestion, here is a summary of changes: 1. Add othervm options to tests: java/rmi/Naming/DefaultRegistryPort.java java/rmi/Naming