Re: 7173494: some jdk tests are not run in test/Makefile

2012-10-08 Thread Chris Hegarty
This update looks ok to me. At some point ( not asking you to do it now ) we will need to update 7u-dev, to avoid confusion around what tests are being run in what batches. -Chris. On 07/10/2012 20:35, Alan Bateman wrote: This one is a small clean-up of the test targets defined in

Re: 7173494: some jdk tests are not run in test/Makefile

2012-10-08 Thread Mandy Chung
It's good to clean this up and the change looks fine in general.A couple of minor comments: jdk_management - Might be good to include java/lang/management tests in this target in case someone only runs one target to verify that area. On the other hands, they are currently covered by

Re: 7173494: some jdk tests are not run in test/Makefile

2012-10-08 Thread Alan Bateman
On 08/10/2012 18:44, Mandy Chung wrote: It's good to clean this up and the change looks fine in general.A couple of minor comments: jdk_management - Might be good to include java/lang/management tests in this target in case someone only runs one target to verify that area. On the other

Re: 7173494: some jdk tests are not run in test/Makefile

2012-10-08 Thread Mandy Chung
On 10/8/2012 11:12 AM, Alan Bateman wrote: On 08/10/2012 18:44, Mandy Chung wrote: It's good to clean this up and the change looks fine in general.A couple of minor comments: jdk_management - Might be good to include java/lang/management tests in this target in case someone only runs

Re: 7173494: some jdk tests are not run in test/Makefile

2012-10-08 Thread Mike Duigou
This looks like all good changes to me. Mike On Oct 7 2012, at 12:35 , Alan Bateman wrote: This one is a small clean-up of the test targets defined in jdk/test/Makefile. The union of the tests executed by each of the make targets should be the entire test suite but this isn't so, there

RE: 7173494: some jdk tests are not run in test/Makefile

2012-10-08 Thread Iris Clark
The webrev with the proposed changes is here: http://cr.openjdk.java.net/~alanb/7173494/webrev/ Looks like a good clean-up. iris

Re: 7173494: some jdk tests are not run in test/Makefile

2012-10-08 Thread Alan Bateman
On 08/10/2012 18:08, Chris Hegarty wrote: This update looks ok to me. At some point ( not asking you to do it now ) we will need to update 7u-dev, to avoid confusion around what tests are being run in what batches. Yes, I think this should go into jdk7u-dev too. -Alan