RE: RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for AIX
Hi Arno, thanks for looking at the change! Best regards, Goetz. > -Original Message- > From: Zeller, Arno > Sent: Dienstag, 22. Januar 2019 14:48 > To: Lindenmaier, Goetz > Cc: core-libs-dev@openjdk.java.net > Subject: RE: RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for > AIX > > Hi Goetz, > > looks good to me and should fix the issue. > I just want to point out that I am not a Reviewer. > > Best regards, > Arno > > >-Original Message- > >From: core-libs-dev On Behalf Of > >Lindenmaier, Goetz > >Sent: Montag, 21. Januar 2019 11:01 > >To: core-libs-dev@openjdk.java.net > >Subject: [CAUTION] RFR(XS): 8217438: Adapt > >tools//launcher/Test7029048.java for AIX > > > >Hi, > > > >please review the following small test fix: > >http://cr.openjdk.java.net/~goetz/wr19/8217438-aix_launcherTest/01/ > > > >The Aix launcher always sets the path to the jdk libraries because > >Aix does not support $ORIGIN to find libjvm.so. > >So some of the test cases here fail. Skip them. > > > >Best regards, > > Goetz.
RE: RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for AIX
Hi Goetz, looks good to me and should fix the issue. I just want to point out that I am not a Reviewer. Best regards, Arno >-Original Message- >From: core-libs-dev On Behalf Of >Lindenmaier, Goetz >Sent: Montag, 21. Januar 2019 11:01 >To: core-libs-dev@openjdk.java.net >Subject: [CAUTION] RFR(XS): 8217438: Adapt >tools//launcher/Test7029048.java for AIX > >Hi, > >please review the following small test fix: >http://cr.openjdk.java.net/~goetz/wr19/8217438-aix_launcherTest/01/ > >The Aix launcher always sets the path to the jdk libraries because >Aix does not support $ORIGIN to find libjvm.so. >So some of the test cases here fail. Skip them. > >Best regards, > Goetz.
RE: RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for AIX
Hi Christoph, thanks for your review. I'll update AIX to Aix before pushing. Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Montag, 21. Januar 2019 11:43 > To: Lindenmaier, Goetz > Cc: core-libs-dev@openjdk.java.net > Subject: RE: RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for > AIX > > Hi Goetz, > > looks good to me. I think it should rather be "AIX" than "Aix" in the output > text > - but it's a developer trace only, so probably nobody cares. > > Best regards > Christoph > > > -Original Message- > > From: core-libs-dev On Behalf > > Of Lindenmaier, Goetz > > Sent: Montag, 21. Januar 2019 11:01 > > To: core-libs-dev@openjdk.java.net > > Subject: [CAUTION] RFR(XS): 8217438: Adapt > > tools//launcher/Test7029048.java for AIX > > > > Hi, > > > > please review the following small test fix: > > http://cr.openjdk.java.net/~goetz/wr19/8217438-aix_launcherTest/01/ > > > > The Aix launcher always sets the path to the jdk libraries because > > Aix does not support $ORIGIN to find libjvm.so. > > So some of the test cases here fail. Skip them. > > > > Best regards, > > Goetz.
RE: RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for AIX
Hi Goetz, looks good to me. I think it should rather be "AIX" than "Aix" in the output text - but it's a developer trace only, so probably nobody cares. Best regards Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Lindenmaier, Goetz > Sent: Montag, 21. Januar 2019 11:01 > To: core-libs-dev@openjdk.java.net > Subject: [CAUTION] RFR(XS): 8217438: Adapt > tools//launcher/Test7029048.java for AIX > > Hi, > > please review the following small test fix: > http://cr.openjdk.java.net/~goetz/wr19/8217438-aix_launcherTest/01/ > > The Aix launcher always sets the path to the jdk libraries because > Aix does not support $ORIGIN to find libjvm.so. > So some of the test cases here fail. Skip them. > > Best regards, > Goetz.
