Re: Re: RFR: JDK-8227831: Avoid using volatile for write-once, read-many class field

2019-07-18 Thread Kazunori Ogata
Redestad , David Holmes > > Cc: core-libs-dev@openjdk.java.net > Date: 2019/07/19 02:59 > Subject: [EXTERNAL] Re: RFR: JDK-8227831: Avoid using volatile for write- > once, read-many class field > Sent by: "core-libs-dev" > > JDK-8219774 is relevant to this patc

Re: RFR: JDK-8227831: Avoid using volatile for write-once, read-many class field

2019-07-18 Thread Mandy Chung
ll the getter, so backport needs to fix them, too. Regards, Ogata Aleksey Shipilev wrote on 2019/07/17 16:49:08: From: Aleksey Shipilev To: Kazunori Ogata , core-libs-dev@openjdk.java.net Date: 2019/07/17 16:49 Subject: [EXTERNAL] Re: RFR: JDK-8227831: Avoid using volatile for write- on

Re: RFR: JDK-8227831: Avoid using volatile for write-once, read-many class field

2019-07-18 Thread Claes Redestad
t do not call the getter, so backport needs to fix them, too. Regards, Ogata Aleksey Shipilev wrote on 2019/07/17 16:49:08: From: Aleksey Shipilev To: Kazunori Ogata , core-libs-dev@openjdk.java.net Date: 2019/07/17 16:49 Subject: [EXTERNAL] Re: RFR: JDK-8227831: Avoid using volatile for write

Re: RFR: JDK-8227831: Avoid using volatile for write-once, read-many class field

2019-07-17 Thread David Holmes
e-libs-dev@openjdk.java.net Date: 2019/07/17 16:49 Subject: [EXTERNAL] Re: RFR: JDK-8227831: Avoid using volatile for write- once, read-many class field On 7/17/19 8:48 AM, Kazunori Ogata wrote: Webrev: http://cr.openjdk.java.net/~ogatak/8227831/webrev/ Note this is generally not safe: it introduces

Re: RFR: JDK-8227831: Avoid using volatile for write-once, read-many class field

2019-07-17 Thread Claes Redestad
on 2019/07/17 16:49:08: From: Aleksey Shipilev To: Kazunori Ogata , core-libs-dev@openjdk.java.net Date: 2019/07/17 16:49 Subject: [EXTERNAL] Re: RFR: JDK-8227831: Avoid using volatile for write- once, read-many class field On 7/17/19 8:48 AM, Kazunori Ogata wrote: Webrev: http://cr.openjd

Re: RFR: JDK-8227831: Avoid using volatile for write-once, read-many class field

2019-07-17 Thread Kazunori Ogata
8: > From: Aleksey Shipilev > To: Kazunori Ogata , core-libs-dev@openjdk.java.net > Date: 2019/07/17 16:49 > Subject: [EXTERNAL] Re: RFR: JDK-8227831: Avoid using volatile for write- > once, read-many class field > > On 7/17/19 8:48 AM, Kazunori Ogata wrote: > > Webre

Re: RFR: JDK-8227831: Avoid using volatile for write-once, read-many class field

2019-07-17 Thread Aleksey Shipilev
On 7/17/19 8:48 AM, Kazunori Ogata wrote: > Webrev: http://cr.openjdk.java.net/~ogatak/8227831/webrev/ Note this is generally not safe: it introduces data race on langReflectAccess field access. It has to be proved that everything that implements LangReflectAccess interface makes this data race

RE: RFR: JDK-8227831: Avoid using volatile for write-once, read-many class field

2019-07-17 Thread Langer, Christoph
Hi Ogata, this seems to make sense. So, +1 from my end. Can you please add a space after "if" in line "734 if(langReflectAccess == null) {"? Thanks Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Kazunori Ogata > Sent: Mittwoch, 17. Juli 2019 08:49