Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-26 Thread Dmitry Samersoff
On 2015-05-21 02:07, Mandy Chung wrote: On May 19, 2015, at 11:51 PM, Dmitry Samersoff dmitry.samers...@oracle.com mailto:dmitry.samers...@oracle.com wrote: Other alternatives could be to do all hashing/sorting/printing on native layer i.e. implement printFinalizationQueue inside VM. Both

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-20 Thread Dmitry Samersoff
Mandy, However I have trouble for Finalizer.printFinalizationQueue method that doesn’t belong there. What are the other alternatives you have explored? Other alternatives could be to do all hashing/sorting/printing on native layer i.e. implement printFinalizationQueue inside VM. Both options

Re: RFR(M, v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-20 Thread Staffan Larsen
Dmitry, I’ve look at the changes on the hotspot side. vm/services/diagnosticCommand.hpp: 270 static const char* impact() { 271 return Low; 272 } I wonder if the impact should be “Medium” instead. There aren’t any good guidelines for what impact means, but finalizerinfo does have

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-20 Thread Peter Levart
On 05/20/2015 10:42 AM, Dmitry Samersoff wrote: Peter, What about creating a special package-private java.lang.ref.DiagnosticCommands class I'm not quite happy with current printFinalizationQueue method - love to have a way to print directly to DCMD pipe from Java rather than return a huge

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-20 Thread Peter Levart
On 05/20/2015 08:51 AM, Dmitry Samersoff wrote: Mandy, However I have trouble for Finalizer.printFinalizationQueue method that doesn’t belong there. What are the other alternatives you have explored? Other alternatives could be to do all hashing/sorting/printing on native layer i.e.

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-20 Thread Dmitry Samersoff
Peter, What about creating a special package-private java.lang.ref.DiagnosticCommands class I'm not quite happy with current printFinalizationQueue method - love to have a way to print directly to DCMD pipe from Java rather than return a huge string to VM. But lang.ref.Finalizer is cached by

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-20 Thread Dmitry Samersoff
Staffan, On 2015-05-20 14:19, Staffan Larsen wrote: Dmitry, I’ve look at the changes on the hotspot side. vm/services/diagnosticCommand.hpp: 270 static const char* impact() { 271 return Low; 272 } I wonder if the impact should be “Medium” instead. There aren’t any good

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-20 Thread Dmitry Samersoff
Peter, I see diagnostic commands mostly format their output in native code. But for some of them (like this finalizer histogram) it would be nice to have a Java wrapper for hotspot's outputStream. I love to have an ability to write pure-java DCMD's without touching of hotspot code but it's a

Re: RFR(M, v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-20 Thread Mandy Chung
On May 19, 2015, at 11:51 PM, Dmitry Samersoff dmitry.samers...@oracle.com wrote: Other alternatives could be to do all hashing/sorting/printing on native layer i.e. implement printFinalizationQueue inside VM. Both options has pros and cons - Java based solution requires less JNI calls

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-19 Thread Peter Levart
Hi Dmitry, This looks good. Just alignment of new code in Finalizer seems a little wobbly. Regards, Peter On 05/18/2015 02:17 PM, Dmitry Samersoff wrote: Everyone, Please review updated version of the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ Most important part

Re: RFR(M, v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-19 Thread Mandy Chung
On May 18, 2015, at 5:17 AM, Dmitry Samersoff dmitry.samers...@oracle.com wrote: Please review updated version of the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ Most important part of the fix

Re: RFR(M, v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-19 Thread Kim Barrett
On May 18, 2015, at 8:17 AM, Dmitry Samersoff dmitry.samers...@oracle.com wrote: Everyone, Please review updated version of the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ Most important part of the fix provided by Peter Levart, so all credentials belongs to

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-19 Thread Derek White
On 5/18/15 8:17 AM, Dmitry Samersoff wrote: Everyone, Please review updated version of the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ Most important part of the fix provided by Peter Levart, so all credentials belongs to him. -Dmitry Looks good to me. I also pinged

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-18 Thread Dmitry Samersoff
Everyone, Please review updated version of the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.07/ Most important part of the fix provided by Peter Levart, so all credentials belongs to him. -Dmitry On 2015-05-16 15:48, Peter Levart wrote: On 05/16/2015 02:38 PM, Peter