Re: RFR(M, v9): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-28 Thread Staffan Larsen
> On 28 maj 2015, at 20:06, Mandy Chung wrote: > > > On 05/28/2015 07:35 AM, Peter Levart wrote: >> Hi Mandy, >> >> On 05/27/2015 03:32 PM, Mandy Chung wrote: >>> Taking it further - is it simpler to return String[] of all classnames >>> including the duplicated ones and have the VM do the co

Re: RFR(M,v9): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-28 Thread Mandy Chung
On 05/28/2015 07:35 AM, Peter Levart wrote: Hi Mandy, On 05/27/2015 03:32 PM, Mandy Chung wrote: Taking it further - is it simpler to return String[] of all classnames including the duplicated ones and have the VM do the count? Are you concerned with the size of the String[]? Yes, the hist

Re: RFR(M,v9): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-28 Thread Peter Levart
Hi Mandy, On 05/27/2015 03:32 PM, Mandy Chung wrote: On May 27, 2015, at 12:34 AM, Peter Levart wrote: Hi Dmitry, The jdk part looks OK (no great changes on this side from last webrev). Is there a particular reason why the return type of printFinalizayionQueue() method is Object[] and not M

Re: RFR(M, v9): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-27 Thread Mandy Chung
> On May 27, 2015, at 12:34 AM, Peter Levart wrote: > > Hi Dmitry, > > The jdk part looks OK (no great changes on this side from last webrev). Is > there a particular reason why the return type of printFinalizayionQueue() > method is Object[] and not Map.Entry[] ? > Taking it further - is i

Re: RFR(M,v9): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-27 Thread Peter Levart
Hi Dmitry, The jdk part looks OK (no great changes on this side from last webrev). Is there a particular reason why the return type of printFinalizayionQueue() method is Object[] and not Map.Entryint[]>[] ? For the hotspot part, I have a few reservations. You expect that the type of array el

Re: RFR(M,v9): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-26 Thread Derek White
On 5/26/15 10:16 AM, Dmitry Samersoff wrote: Hi Everybody, http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.09/ Please review updated webrev - printFinalizationQueue now returns and array of Map.Entry Hi Dmitry, I looked at the jdk_webrev. Everything looks great except the spacing

Re: RFR(M,v9): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-26 Thread Dmitry Samersoff
Hi Everybody, http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.09/ Please review updated webrev - printFinalizationQueue now returns and array of Map.Entry >> On May 19, 2015, at 11:51 PM, Dmitry Samersoff >> mailto:dmitry.samers...@oracle.com>> wrote: >> >> Other alternatives could be