Typo in CatchExceptionTest.java:
66 private int droped;
Should be “dropped”.
Otherwise seems ok... But more comments would be appreciated. It’s huge and
really hard to understand.
igor
On Mar 28, 2014, at 9:04 AM, Igor Ignatyev igor.ignat...@oracle.com wrote:
Vladimir,
as we'd
Igor,
Thanks for review.
Should be “dropped”.
fixed
But more comments would be appreciated. It’s huge and really hard to understand.
sure, I'll add them during future improvements.
Igor
On 03/29/2014 05:07 AM, Igor Veresov wrote:
Typo in CatchExceptionTest.java:
66 private int
On Mar 28, 2014, at 2:29 AM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
PS: John mentioned recently that there's a convention for java/lang/invoke
tests to be in JUnit format. I'm not sure it'll improve the code in any way
(maybe TestNG will?). I hope John will express his opinion
John,
unfortunately, I've already pushed my changes w/o junit annotation. But
I have the dirty patch which adds jtreg support to netbeans:
1. add test.single action for test folder to 'ide-actions' section in
JDK project -- jdk/make/netbeans/j2se/nbproject/project.xml:
Igor, thanks for improving the tests on method handles!
After an offline conversation w/ VladimirI, I've done several changes:
- placed all classes into one file (but I don't like it)
You can convert TestCase TestFactory to inner classes and move
ThrowMode into TestCase since it's usage is
Vladimir, thanks for review, please my comments inline.
On 03/28/2014 01:29 PM, Vladimir Ivanov wrote:
Igor, thanks for improving the tests on method handles!
After an offline conversation w/ VladimirI, I've done several changes:
- placed all classes into one file (but I don't like it)
You
Vladimir,
as we'd arranged, I moved ThrowMode into TestCase and give my word that
I'll
remove TestCase.assertEQ and enhance Asserts.assertEquals for arrays
add the test cases from TestCatchException to 'MANDATORY_TEST_CASES' in
CatchExceptionTest and remove TestCatchException
in JDK9 TF.
After an offline conversation w/ VladimirI, I've done several changes:
- placed all classes into one file (but I don't like it)
- changed package name
- extracted creating tests code from test execution code
I hope the code's still quite readable and understandable.
Also I've added array return
On Mar 24, 2014, at 1:33 PM, Igor Ignatyev igor.ignat...@oracle.com wrote:
Hi all,
Please review the patch:
Problems:
- MethodHandlesTest::testCatchException() doesn't provide enough testing of
j.l.i.MethodHandles::catchException().
- MethodHandlesTest contains more than 3k lines, an
Hi Chris,
This is very nice. Are there plans to do this for the other existing tests as
well?
sure, but we didn't have enough time to do it in 8u20 timeframe. So I'd
like to push these changes 1st, since we need this to cover 'Speedup
catch exceptions'. Other tests will be rewrite later. I
Hi all,
Please review the patch:
Problems:
- MethodHandlesTest::testCatchException() doesn't provide enough testing
of j.l.i.MethodHandles::catchException().
- MethodHandlesTest contains more than 3k lines, an auxiliary code
together w/ a test code, many methods aren't connected w/ each
11 matches
Mail list logo
