Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-15 Thread roger riggs
Hi Martin, A followup, what is the subtlety that makes it beneficial to wrap even a single statement in a do {} while (0)? It makes sense for macros with multiple statements but not for a single statement substitution of expressions. For a single statement (w/o ';'), it seems like a redundant

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-14 Thread roger riggs
Hi David, The CHECK_RETURN macros have existed in java.net for some time and I have not seen any empty statement warnings. The CHECK_EXCEPTION macros are new and does not have any uses yet. I don't plan to do any wholesale modification of current sources. The macros always produce a valid

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-13 Thread David Holmes
Hi Roger, On 11/01/2014 1:37 AM, roger riggs wrote: Please review: To enable native code checking consistently for thrown exceptions, the macros in net_util.h and java/util/jar/pack/coding.cpp are made consolidated and promoted to jni_util.h webrev:

RFR: (8030875) Macros for checking and returning on exceptions

2014-01-10 Thread roger riggs
Please review: To enable native code checking consistently for thrown exceptions, the macros in net_util.h and java/util/jar/pack/coding.cpp are made consolidated and promoted to jni_util.h webrev: http://cr.openjdk.java.net/~rriggs/webrev-check-exception-8030875/ [1]

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-10 Thread Chris Hegarty
Thank you Roger, much appreciated. I think Dan has a change in flight that could be simplified a bit by using these. -Chris. On 10/01/14 15:37, roger riggs wrote: Please review: To enable native code checking consistently for thrown exceptions, the macros in net_util.h and

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-10 Thread Alan Bateman
On 10/01/2014 15:37, roger riggs wrote: Please review: To enable native code checking consistently for thrown exceptions, the macros in net_util.h and java/util/jar/pack/coding.cpp are made consolidated and promoted to jni_util.h webrev:

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-10 Thread Michael McMahon
On 10/01/14 15:37, roger riggs wrote: Please review: To enable native code checking consistently for thrown exceptions, the macros in net_util.h and java/util/jar/pack/coding.cpp are made consolidated and promoted to jni_util.h webrev:

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-10 Thread Mandy Chung
On 1/10/2014 7:37 AM, roger riggs wrote: Please review: To enable native code checking consistently for thrown exceptions, the macros in net_util.h and java/util/jar/pack/coding.cpp are made consolidated and promoted to jni_util.h webrev:

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-10 Thread roger riggs
Hi Mandy, Good point; I'll create another issue to do that update. (I should have waited a bit longer for comments.) Roger On 1/10/2014 12:41 PM, Mandy Chung wrote: On 1/10/2014 7:37 AM, roger riggs wrote: Please review: To enable native code checking consistently for thrown exceptions, the