Re: RFR: JDK-8022178: System.console() throws IOE on some Windows

2013-08-14 Thread Dan Xu
Looks good to me. -Dan On 08/14/2013 11:35 AM, Alan Bateman wrote: On 14/08/2013 19:35, Xueming Shen wrote: Hi, Please help review the trivial change for 8022178. http://cr.openjdk.java.net/~sherman/console/webrev System.console() is not specified to throw an IOE. It is supposed to return a

Re: RFR: JDK-8022178: System.console() throws IOE on some Windows

2013-08-14 Thread Alan Bateman
On 14/08/2013 19:35, Xueming Shen wrote: Hi, Please help review the trivial change for 8022178. http://cr.openjdk.java.net/~sherman/console/webrev System.console() is not specified to throw an IOE. It is supposed to return a null silently if there is no system console or anything goes wrong to

RFR: JDK-8022178: System.console() throws IOE on some Windows

2013-08-14 Thread Xueming Shen
Hi, Please help review the trivial change for 8022178. http://cr.openjdk.java.net/~sherman/console/webrev System.console() is not specified to throw an IOE. It is supposed to return a null silently if there is no system console or anything goes wrong to get one. The Windows implementation obvio