RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2015-01-02 Thread Amit Baxi
Hi Folks, We are facing issue with process builder on JRockit JVM with solaris 5.10 machine. That is realted to following bug: http://bugs.java.com/view_bug.do?bug_id=5049299 Currently we are using JRockit JDK 1.6.0_37-R28.2.5-4.1.0 version. Please let me know following : *

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-08 Thread Alan Bateman
On 08/11/2013 00:39, David Holmes wrote: And linux? It has changed to vfork right? So OSX has changed, linux has changed, but Solaris remains as-is. All platforms allow selecting the mechanism via the property jdk.lang.Process.launchMechanism The only change is OSX where the default

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-08 Thread Rob McKenna
vfork was the default in Linux before 5049299. You can see the variable START_CHILD_USE_VFORK being set in: http://cr.openjdk.java.net/~robm/5049299/webrev.06/src/solaris/native/java/lang/UNIXProcess_md.c.cdiff.html -Rob On 08/11/13 00:39, David Holmes wrote: On 7/11/2013 11:53 PM, Rob

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-07 Thread Rob McKenna
Ah, thanks for catching that David, I've updated the webrev in place. I believe the reasoning is that we want to minimise any potential impact to customers running in production. The general feeling seems to be that Mac is a development platform and is less likely to cause us problems in that

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-07 Thread Rob McKenna
I've added a review showing the differences to jdk8 to: http://cr.openjdk.java.net/~robm/5049299/7/webrev.02/ I've updated the previous webrev ( http://cr.openjdk.java.net/~robm/5049299/7/webrev.01/ ) in place to reflect the comment change. Note: still putting together a separate test which

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-07 Thread Alan Bateman
On 07/11/2013 13:52, Rob McKenna wrote: I've added a review showing the differences to jdk8 to: http://cr.openjdk.java.net/~robm/5049299/7/webrev.02/ That makes it easy, thanks. At L100 then I assume you mean posix_spawn rather than spawn. -Alan

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-07 Thread David Holmes
On 7/11/2013 11:53 PM, Rob McKenna wrote: Ah, thanks for catching that David, I've updated the webrev in place. I believe the reasoning is that we want to minimise any potential impact to customers running in production. The general feeling seems to be that Mac is a development platform and is

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-06 Thread Rob McKenna
Hi Alan, On 06/11/13 09:05, Alan Bateman wrote: On 05/11/2013 21:37, Rob McKenna wrote: Apologies, I forgot to mention the dependency on: 8008118: (process) Possible null pointer dereference in jdk/src/solaris/native/java/lang/UNIXProcess_md.c

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-06 Thread Rob McKenna
Hi David, The only difference in 5049299 is the change in the default property value in Solaris. Apologies for not making that clear. -Rob On 06/11/13 01:09, David Holmes wrote: Hi Rob, How different is this to the JDK 8 version? Thanks, David On 6/11/2013 7:24 AM, Rob McKenna wrote:

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-06 Thread Alan Bateman
On 06/11/2013 13:30, Rob McKenna wrote: Yes, absolutely. I'm looking for approval for the code in principle. Particularly the change in the default property value on Solaris since thats the only change. Once approved I will of course seek approval for integration. I think the proposal is

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-06 Thread Alan Bateman
On 05/11/2013 21:37, Rob McKenna wrote: Apologies, I forgot to mention the dependency on: 8008118: (process) Possible null pointer dereference in jdk/src/solaris/native/java/lang/UNIXProcess_md.c http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0111bab8dc35 -Rob To keep the changes the same

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-06 Thread David Holmes
On 6/11/2013 10:00 PM, Rob McKenna wrote: Hi David, The only difference in 5049299 is the change in the default property value in Solaris. Apologies for not making that clear. Given this was primarily aimed at Solaris in the first place it seems strange to me to not make the change on

RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-05 Thread Rob McKenna
Hi folks, I'd like to backport this change to JDK7. Note: this fix uses posix_spawn by default on Mac OSX only. On Solaris fork will remain the default behaviour. I've just noticed that there is a problem with the testcase on Solaris in that it will test fork twice. (and won't test

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-05 Thread Rob McKenna
.. http://cr.openjdk.java.net/~robm/5049299/7/webrev.01/ -Rob On 05/11/13 21:23, Rob McKenna wrote: Hi folks, I'd like to backport this change to JDK7. Note: this fix uses posix_spawn by default on Mac OSX only. On Solaris fork will remain the default behaviour. I've just noticed

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-05 Thread Rob McKenna
Apologies, I forgot to mention the dependency on: 8008118: (process) Possible null pointer dereference in jdk/src/solaris/native/java/lang/UNIXProcess_md.c http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0111bab8dc35 -Rob On 05/11/13 21:24, Rob McKenna wrote: ..

Re: RFR: 5049299 - (process) Use,posix_spawn, not fork, on S10 to avoid swap,exhaustion (jdk7u-dev)

2013-11-05 Thread David Holmes
Hi Rob, How different is this to the JDK 8 version? Thanks, David On 6/11/2013 7:24 AM, Rob McKenna wrote: .. http://cr.openjdk.java.net/~robm/5049299/7/webrev.01/ -Rob On 05/11/13 21:23, Rob McKenna wrote: Hi folks, I'd like to backport this change to JDK7. Note: this fix uses