On Thu, 24 Jun 2021 21:20:29 GMT, Naoto Sato wrote:
> Fine by me.
Thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/4589
On Thu, 24 Jun 2021 20:01:27 GMT, Brian Burkhalter wrote:
> Merge identical Unix and Windows versions of FileOutputStream_md.c into
> single, common FileOutputStream.c.
Fine by me.
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4589
On Thu, 24 Jun 2021 20:01:27 GMT, Brian Burkhalter wrote:
> Merge identical Unix and Windows versions of FileOutputStream_md.c into
> single, common FileOutputStream.c.
The `fileOpen()`, `writeSingle()`, and `writeBytes()` functions called here all
expect to receive a field ID. This might be
On Thu, 24 Jun 2021 20:01:27 GMT, Brian Burkhalter wrote:
> Merge identical Unix and Windows versions of FileOutputStream_md.c into
> single, common FileOutputStream.c.
Looks good. Would you consider removing `fos_fd` and passing it as a `jlong` as
suggested in the issue?
-
PR:
Merge identical Unix and Windows versions of FileOutputStream_md.c into single,
common FileOutputStream.c.
-
Commit messages:
- 6633375: FileOutputStream_md.c should be merged into FileOutputStream.c
Changes: https://git.openjdk.java.net/jdk/pull/4589/files
Webrev:
