Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2022-03-29 Thread Jaikiran Pai
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However,

Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2022-01-31 Thread Jaikiran Pai
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However,

Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2021-12-06 Thread Roger Riggs
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However,

Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2021-12-03 Thread Stuart Marks
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However,

Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2021-12-03 Thread Stuart Marks
On Sat, 4 Dec 2021 00:02:04 GMT, Brent Christian wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.java.net/browse/JDK-8003417? >> >> The issue notes that this is applicable for `WeakHashMap` which have `null` >> keys.

Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2021-12-03 Thread Brent Christian
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However,

Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2021-12-03 Thread Roger Riggs
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However,

Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2021-12-02 Thread Jaikiran Pai
On Thu, 2 Dec 2021 19:04:11 GMT, Roger Riggs wrote: > fyi, with this change the JCK did not flag a failure. Thank you Roger for running those tests. - PR: https://git.openjdk.java.net/jdk/pull/6488

Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2021-12-02 Thread Roger Riggs
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However,

Re: RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2021-11-29 Thread Jaikiran Pai
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However,

RFR: 8003417: WeakHashMap$HashIterator removes wrong entry

2021-11-20 Thread Jaikiran Pai
Can I please get a review for this change which proposes to fix the issue reported in https://bugs.openjdk.java.net/browse/JDK-8003417? The issue notes that this is applicable for `WeakHashMap` which have `null` keys. However, the issue is even applicable for `WeakHashMap` instances which