Re: RFR: 8029055: Map.merge @implDoc is incorrect.

2013-11-24 Thread David Holmes
Hi Mike, There is still no clear spec for what should happen if the param value is null. To me the spec implies that null should become the new value for the mapping, but the code actually removes the mapping. There is also a further error in this spec. First we have: 1112 * If the spec

Re: RFR: 8029055: Map.merge @implDoc is incorrect. (was: Map.merge Javadoc is confusing)

2013-11-22 Thread Henry Jen
+1 (Not a reviewer). Cheers, Henry On Fri 22 Nov 2013 04:25:50 PM PST, Mike Duigou wrote: We'll be using https://bugs.openjdk.java.net/browse/JDK-8029055 for this issue. I've posted a webrev here: http://cr.openjdk.java.net/~mduigou/JDK-8029055/0/webrev/ There is an identical change in Concu

RFR: 8029055: Map.merge @implDoc is incorrect. (was: Map.merge Javadoc is confusing)

2013-11-22 Thread Mike Duigou
We'll be using https://bugs.openjdk.java.net/browse/JDK-8029055 for this issue. I've posted a webrev here: http://cr.openjdk.java.net/~mduigou/JDK-8029055/0/webrev/ There is an identical change in ConcurrentMap's merge(). Mike On Nov 22 2013, at 16:01 , Henry Jen wrote: > > On 11/21/2013 06