Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-18 Thread Serge
Hi all. Please review the second fix http://cr.openjdk.java.net/~yan/8029451/webrev.03 http://cr.openjdk.java.net/%7Eyan/8029451/webrev.03 for https://bugs.openjdk.java.net/browse/JDK-8029451 As suggest Martin, I replaced a name= to p id= in java/util/ArrayList.java. In

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-18 Thread roger riggs
Hi Sergey, java/util/Vector.java could use the id=xxx idiom instead of a name= ... In java/util/zip/package.html I would omit the extra p tags; the style sheet should be providing the spacing. The rest looks fine: (Not a Reviewer) Roger On 12/18/2013 9:38 AM, Serge wrote: Hi all. Please

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-06 Thread Alan Bateman
On 05/12/2013 05:30, Sergey Lugovoy wrote: Hi all, please review the fix http://cr.openjdk.java.net/~yan/8029451/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8029451 This patch cleanup tidy warnings for generated html documentation, and do not affect the appearance of the

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-06 Thread roger riggs
+1, It can be used with any tag (not just p, including h3, ul, li, br, etc.) On 12/6/2013 1:09 AM, Martin Buchholz wrote: In jsr166-land we recently started using p id=TAG, which I recommend, e.g. AbstractQueuedSynchronizer.java:122: * p id=bargingBecause checks in acquire are invoked

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-06 Thread Michael McMahon
On 06/12/13 11:44, Alan Bateman wrote: On 05/12/2013 05:30, Sergey Lugovoy wrote: Hi all, please review the fix http://cr.openjdk.java.net/~yan/8029451/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8029451 This patch cleanup tidy warnings for generated html documentation, and do

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-06 Thread Joe Darcy
On 12/06/2013 09:20 AM, Martin Buchholz wrote: FYI: When I run javadoc on jsr166 CVS (it's not too hard for y'all to do this as well), I still see many warnings inherited from openjdk8 source: $ ant docs ... [javadoc] Constructing Javadoc information... [javadoc] Standard Doclet version

RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-05 Thread Sergey Lugovoy
Hi all, please review the fix http://cr.openjdk.java.net/~yan/8029451/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8029451 This patch cleanup tidy warnings for generated html documentation, and do not affect the appearance of the documentation. Best regards, Serge V. Lugovoy

Re: RFR: 8029451 : Tidy warnings cleanup for java.util package

2013-12-05 Thread Paul Sandoz
On Dec 5, 2013, at 6:30 AM, Sergey Lugovoy sergey.lugo...@oracle.com wrote: Hi all, please review the fix http://cr.openjdk.java.net/~yan/8029451/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8029451 This patch cleanup tidy warnings for generated html documentation, and do not