Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Mike Duigou
I and others have tried to track down the compiler issue in which this change was made. If anyone can point us in the right direction it would be nice to reference that issue. Mike On Apr 11 2014, at 13:09 , Chris Hegarty wrote: > >> On 11 Apr 2014, at 21:04, Mike Duigou wrote: >> >> Appar

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Chris Hegarty
> On 11 Apr 2014, at 21:04, Mike Duigou wrote: > > Apparently javac did at elide the "extraneous" null initialization at one > point and it was deemed to have been contrary to point #4 of the procedure in > JLS 12.5 > (http://docs.oracle.com/javase/specs/jls/se7/html/jls-12.html#jls-12.5-220-

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Chris Hegarty
This look good to me. I'm really happy to see these do away. I'll help clean up other areas too. -Chris > On 11 Apr 2014, at 20:22, Mike Duigou wrote: > > Hello all; > > This is a simple cleanup changeset that removes redundant initialization of > fields to null from a number of collection c

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Mike Duigou
Apparently javac did at elide the "extraneous" null initialization at one point and it was deemed to have been contrary to point #4 of the procedure in JLS 12.5 (http://docs.oracle.com/javase/specs/jls/se7/html/jls-12.html#jls-12.5-220-D) Mike On Apr 11 2014, at 12:57 , Martin Buchholz wrote

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Aleksey Shipilev
On 04/11/2014 11:22 PM, Mike Duigou wrote: > https://bugs.openjdk.java.net/browse/JDK-8035284 > http://cr.openjdk.java.net/~mduigou/JDK-8035284/0/webrev/ This! Thumbs up. > Redundant null initializations in other components/packages will be handled > in separate issues. I also remember seeing c

Re: RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Lance @ Oracle
Looks fine mike Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 11, 2014, at 3:22 PM, Mike Duigou wrote: > Hello all; > > This is a simple cleanup changeset t

RFR: 8035284: (xs) Remove redundant null initialization

2014-04-11 Thread Mike Duigou
Hello all; This is a simple cleanup changeset that removes redundant initialization of fields to null from a number of collection classes. These field initializations may seem cheap but they do have a cost: - For volatile fields there is a measurable cost on some benchmarks for these extra ini