Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

> On Apr 19, 2017, at 11:26 AM, Kumar Srinivasan > wrote: > > > Made the change you recommended, and here is the updated webrev > http://cr.openjdk.java.net/~ksrini/8076417/webrev.01/ +1 Mandy

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

On 4/20/17 2:26 AM, Kumar Srinivasan wrote: Made the change you recommended, and here is the updated webrev http://cr.openjdk.java.net/~ksrini/8076417/webrev.01/ Thank you Kumar!Looks good. (I'm not official reviewer) Thanks, Amy Thanks Kumar Hi, Kumar As the removed test is the only

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Made the change you recommended, and here is the updated webrev http://cr.openjdk.java.net/~ksrini/8076417/webrev.01/ Thanks Kumar Hi, Kumar As the removed test is the only one test under jdk/asm, it needs to be removed from jdk_other test group: --- a/test/TEST.groups +++

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Ah, yes, good catch. Thanks Amy. Kumar Hi, Kumar As the removed test is the only one test under jdk/asm, it needs to be removed from jdk_other test group: --- a/test/TEST.groups +++ b/test/TEST.groups @@ -269,7 +269,6 @@ javax/transaction \ javax/xml \ -javax/xml/crypto \ -

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Hi, Kumar As the removed test is the only one test under jdk/asm, it needs to be removed from jdk_other test group: --- a/test/TEST.groups +++ b/test/TEST.groups @@ -269,7 +269,6 @@ javax/transaction \ javax/xml \ -javax/xml/crypto \ -jdk/asm \ Thanks, Amy On 4/19/17

Re: RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

+1 -Sundar On 19/04/17, 12:09 AM, Kumar Srinivasan wrote: Hello, Please review [1] which addresses bug [2]. This test is unnecessary, as there are other components and tests within the jdk, which will fail if ASM is not included, therefore this test is removed. Thanks Kumar [1]

RFR: 8076417: Update test/jdk/asm/AsmSanity.java with modules

Hello, Please review [1] which addresses bug [2]. This test is unnecessary, as there are other components and tests within the jdk, which will fail if ASM is not included, therefore this test is removed. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8076417/webrev.00/ [2]